DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
	"Kurakin, Ilia" <ilia.kurakin@intel.com>
Cc: DPDK <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Khatko, Roman P" <roman.p.khatko@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach
Date: Wed, 22 Aug 2018 18:13:46 +0100	[thread overview]
Message-ID: <4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com> (raw)
In-Reply-To: <FBA6DD83-6456-4F97-926D-A5FEBB381CA0@intel.com>

On 7/24/2018 2:17 PM, Wiles, Keith wrote:
> 
> 
>> On Jul 19, 2018, at 7:21 AM, ilia.kurakin@intel.com wrote:
>>
>> From: Ilia Kurakin <ilia.kurakin@intel.com>
>>
>> The patch changes rx_burst profiling approach:
>> 	1. VTune's instrumentation is removed
>> 	2. empty hook callback for profiling is added
>> This way all VTune-specific logic moves to the VTune side.
>> Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option
>> is turned on. VTune uses this hook to attach to the polling cycle. It
>> is not possible to attach to the rx_burst directly, as it is inline.
>>
>> Signed-off-by: Ilia Kurakin <ilia.kurakin@intel.com>
>>
>> ---
>>
>> -v2 change:
>> 	fix coding style issue, re-merge
>>
>> config/common_base                    |   2 +-
>> doc/guides/prog_guide/profile_app.rst |  34 ++---------
>> lib/librte_ethdev/ethdev_profile.c    | 103 +++++-----------------------------
>> lib/librte_ethdev/ethdev_profile.h    |   6 +-
>> lib/librte_ethdev/rte_ethdev.c        |   4 +-
>> 5 files changed, 25 insertions(+), 124 deletions(-)
>>
> 
> Looks good and a cleaner method.
> 
> Acked-by: Keith Wiles <keith.wiles@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

  reply	other threads:[~2018-08-22 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 13:11 [dpdk-dev] [PATCH] " ilia.kurakin
2018-07-19 12:21 ` [dpdk-dev] [PATCH v2] " ilia.kurakin
2018-07-24 13:17   ` Wiles, Keith
2018-08-22 17:13     ` Ferruh Yigit [this message]
2018-08-23  9:35       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ilia.kurakin@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=roman.p.khatko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).