From: Ferruh Yigit <ferruh.yigit@amd.com>
To: luca.boccassi@gmail.com, dev@dpdk.org
Subject: Re: [PATCH kmods] linux/igb_uio: fix build on Linux 5.18+
Date: Sun, 18 Dec 2022 14:24:55 +0000 [thread overview]
Message-ID: <4a59bead-6998-3a21-597c-6eb1c6c25d69@amd.com> (raw)
In-Reply-To: <20221216171801.348224-1-luca.boccassi@gmail.com>
On 12/16/2022 5:18 PM, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <bluca@debian.org>
>
> Reported-by: Paolo Pisati <p.pisati@gmail.com>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> Only build-tested.
>
> linux/igb_uio/igb_uio.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 33e0e02..3d8a8a8 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -512,13 +512,21 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> goto fail_release_iomem;
>
> /* set 64-bit DMA mask */
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 18, 0)
> err = pci_set_dma_mask(dev, DMA_BIT_MASK(64));
> +#else
> + err = dma_set_mask(&dev->dev, DMA_BIT_MASK(64));
> +#endif
Hi Luca,
Can you please check following, I guess these patches are for same issue:
https://patches.dpdk.org/project/dpdk/patch/20221216115732.3552650-1-ferruh.yigit@amd.com/
> if (err != 0) {
> dev_err(&dev->dev, "Cannot set DMA mask\n");
> goto fail_release_iomem;
> }
>
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 18, 0)
> err = pci_set_consistent_dma_mask(dev, DMA_BIT_MASK(64));
> +#else
> + err = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(64));
> +#endif
> if (err != 0) {
> dev_err(&dev->dev, "Cannot set consistent DMA mask\n");
> goto fail_release_iomem;
next prev parent reply other threads:[~2022-12-18 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 17:18 luca.boccassi
2022-12-18 14:24 ` Ferruh Yigit [this message]
2022-12-22 15:35 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a59bead-6998-3a21-597c-6eb1c6c25d69@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).