patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Pascal Mazon <pascal.mazon@6wind.com>
To: Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Olga Shern <olgas@mellanox.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v1] net/tap: fix report on multi segments capability
Date: Mon, 5 Feb 2018 15:53:13 +0100	[thread overview]
Message-ID: <4a6a25e0-ee22-97f9-95bd-8feecd0ee9d2@6wind.com> (raw)
In-Reply-To: <1517828348-488-1-git-send-email-ophirmu@mellanox.com>

Acked-by: Pascal Mazon <pascal.mazon@6wind.com>

On 05/02/2018 11:59, Ophir Munk wrote:
> TAP device is supporting multi segments Tx, however this capability is
> not reported when querying the TAP device.
> This commit adds this capability report.
>
> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index dc3847e..ac43db4 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -390,7 +390,8 @@ tap_tx_offload_get_port_capa(void)
>  	 * In order to support legacy apps,
>  	 * report capabilities also as port capabilities.
>  	 */
> -	return DEV_TX_OFFLOAD_IPV4_CKSUM |
> +	return DEV_TX_OFFLOAD_MULTI_SEGS |
> +	       DEV_TX_OFFLOAD_IPV4_CKSUM |
>  	       DEV_TX_OFFLOAD_UDP_CKSUM |
>  	       DEV_TX_OFFLOAD_TCP_CKSUM;
>  }
> @@ -398,7 +399,8 @@ tap_tx_offload_get_port_capa(void)
>  static uint64_t
>  tap_tx_offload_get_queue_capa(void)
>  {
> -	return DEV_TX_OFFLOAD_IPV4_CKSUM |
> +	return DEV_TX_OFFLOAD_MULTI_SEGS |
> +	       DEV_TX_OFFLOAD_IPV4_CKSUM |
>  	       DEV_TX_OFFLOAD_UDP_CKSUM |
>  	       DEV_TX_OFFLOAD_TCP_CKSUM;
>  }

  reply	other threads:[~2018-02-05 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 10:59 Ophir Munk
2018-02-05 14:53 ` Pascal Mazon [this message]
2018-02-05 18:02   ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2018-02-05 10:56 Ophir Munk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a6a25e0-ee22-97f9-95bd-8feecd0ee9d2@6wind.com \
    --to=pascal.mazon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=olgas@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).