From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build
Date: Sat, 22 Apr 2023 14:26:40 +0900 [thread overview]
Message-ID: <4b2afbbe-9335-e0b4-24ad-32e7cc7ad194@daynix.com> (raw)
In-Reply-To: <AS8PR08MB7080124440E541A1F17AFE8A9E639@AS8PR08MB7080.eurprd08.prod.outlook.com>
On 2023/04/20 16:20, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Akihiko Odaki <akihiko.odaki@daynix.com>
>> Sent: Friday, April 14, 2023 8:42 PM
>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson <bruce.richardson@intel.com>
>> Cc: dev@dpdk.org; Akihiko Odaki <akihiko.odaki@daynix.com>
>> Subject: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build
>>
>> We enable NUMA even if the presence of NUMA is unknown for the other architectures. Enable
>> NUMA for generic Arm build too.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>> config/arm/meson.build | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index 724c00ad7e..f8ee7cdafb
>> 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -271,13 +271,15 @@ implementers = {
>> soc_generic = {
>> 'description': 'Generic un-optimized build for armv8 aarch64 exec mode',
>> 'implementer': 'generic',
>> - 'part_number': 'generic'
>> + 'part_number': 'generic',
>> + 'numa': true
>
> The default value of numa is true. So no need to add it here?
>
> if not soc_config.get('numa', true)
> has_libnuma = 0
> endif
You're right. I confirmed this change is unnecessary. Please ignore this
patch and consider merging only the first patch of this series.
>
>> }
>>
>> soc_generic_aarch32 = {
>> 'description': 'Generic un-optimized build for armv8 aarch32 exec mode',
>> 'implementer': 'generic',
>> - 'part_number': 'generic_aarch32'
>> + 'part_number': 'generic_aarch32',
>> + 'numa': true
>> }
>>
>> soc_armada = {
>> --
>> 2.40.0
>
prev parent reply other threads:[~2023-04-22 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:41 [PATCH 0/2] Enable " Akihiko Odaki
2023-04-14 12:41 ` [PATCH 1/2] config/arm: Do not require processor information Akihiko Odaki
2023-04-17 7:41 ` Ruifeng Wang
2023-04-20 1:40 ` Akihiko Odaki
2023-04-20 7:10 ` Ruifeng Wang
2023-04-20 7:12 ` Akihiko Odaki
2023-05-04 7:47 ` Akihiko Odaki
2023-05-04 9:43 ` Ruifeng Wang
2023-05-04 15:08 ` Akihiko Odaki
2023-05-29 7:37 ` Juraj Linkeš
2023-04-14 12:41 ` [PATCH 2/2] config/arm: Enable NUMA for generic Arm build Akihiko Odaki
2023-04-20 7:20 ` Ruifeng Wang
2023-04-22 5:26 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b2afbbe-9335-e0b4-24ad-32e7cc7ad194@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).