From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>, dev@dpdk.org
Cc: stephen@networkplumber.org, nicolas.dichtel@6wind.com
Subject: Re: [dpdk-dev] [PATCH v6 2/5] igb_uio: fix irq disable on recent kernels
Date: Mon, 4 Sep 2017 22:32:53 +0100 [thread overview]
Message-ID: <4bfac191-103f-54c8-3ffc-f094ec6f8f44@intel.com> (raw)
In-Reply-To: <1504549066-11067-2-git-send-email-markus.theil@tu-ilmenau.de>
On 9/4/2017 7:17 PM, Markus Theil wrote:
> igb_uio already allocates irqs using pci_alloc_irq_vectors on
> recent kernels >= 4.8. The interrupt disable code was not
> using the corresponding pci_free_irq_vectors, but the also
> deprecated pci_disable_msix, before this fix.
>
> Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for MSI-X")
> Cc: nicolas.dichtel@6wind.com
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
<...>
> -#ifdef HAVE_PCI_ENABLE_MSIX
> +#ifndef HAVE_ALLOC_IRQ_VECTORS
> msix_entry.entry = 0;
> if (pci_enable_msix(udev->pdev, &msix_entry, 1) == 0) {
> dev_dbg(&udev->pdev->dev, "using MSI-X");
> - udev->info.irq_flags = IRQF_NO_THREAD;
This and below one [1] seems merge artifact, needs to be removed from
this patch.
> udev->info.irq = msix_entry.vector;
> udev->mode = RTE_INTR_MODE_MSIX;
> break;
> @@ -331,6 +330,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
> #else
> if (pci_alloc_irq_vectors(udev->pdev, 1, 1, PCI_IRQ_MSIX) == 1) {
> dev_dbg(&udev->pdev->dev, "using MSI-X");
> + udev->info.irq_flags = IRQF_NO_THREAD;
[1]
> udev->info.irq = pci_irq_vector(udev->pdev, 0);
> udev->mode = RTE_INTR_MODE_MSIX;
> break;
<...>
next prev parent reply other threads:[~2017-09-04 21:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 17:33 [dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored Markus Theil
2017-08-21 17:51 ` [dpdk-dev] [PATCH v2 1/2] " Markus Theil
2017-08-21 17:51 ` [dpdk-dev] [PATCH v2 2/2] igb_uio: conform to coding conventions Markus Theil
2017-08-22 13:28 ` [dpdk-dev] [PATCH v3] igb_uio: MSI IRQ mode, irq enable/disable refactored Markus Theil
2017-08-30 16:32 ` Ferruh Yigit
2017-08-31 22:05 ` Markus Theil
2017-08-31 10:22 ` [dpdk-dev] [PATCH v4 1/3] igb_uio: refactor irq enable/disable into own functions Markus Theil
2017-08-31 10:22 ` [dpdk-dev] [PATCH v4 2/3] igb_uio: fix irq disable on recent kernels Markus Theil
2017-08-31 10:22 ` [dpdk-dev] [PATCH v4 3/3] igb_uio: MSI IRQ mode Markus Theil
2017-08-31 15:32 ` Stephen Hemminger
2017-08-31 22:07 ` Markus Theil
2017-08-31 21:46 ` [dpdk-dev] [PATCH v5 1/5] igb_uio: refactor irq enable/disable into own functions Markus Theil
2017-08-31 21:46 ` [dpdk-dev] [PATCH v5 2/5] igb_uio: fix irq disable on recent kernels Markus Theil
2017-08-31 21:46 ` [dpdk-dev] [PATCH v5 3/5] igb_uio: MSI IRQ mode Markus Theil
2017-08-31 21:46 ` [dpdk-dev] [PATCH v5 4/5] igb_uio: use msi mask functions from kernel, little corrections Markus Theil
2017-09-01 15:40 ` Stephen Hemminger
2017-09-04 10:03 ` Burakov, Anatoly
2017-09-04 12:43 ` Ferruh Yigit
2017-09-04 15:16 ` Markus Theil
2017-09-04 16:55 ` Ferruh Yigit
2017-08-31 21:47 ` [dpdk-dev] [PATCH v5 5/5] igb_uio: release in exact reverse order Markus Theil
2017-08-22 16:55 ` [dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored Stephen Hemminger
2017-08-22 18:19 ` Markus Theil
2017-08-23 8:47 ` Bruce Richardson
2017-08-23 8:51 ` Bruce Richardson
2017-09-04 18:17 ` [dpdk-dev] [PATCH v6 1/5] igb_uio: refactor irq enable/disable into own functions Markus Theil
2017-09-04 18:17 ` [dpdk-dev] [PATCH v6 2/5] igb_uio: fix irq disable on recent kernels Markus Theil
2017-09-04 21:32 ` Ferruh Yigit [this message]
2017-09-04 18:17 ` [dpdk-dev] [PATCH v6 3/5] igb_uio: fix MSI-X IRQ assignment with new IRQ function Markus Theil
2017-09-04 21:34 ` Ferruh Yigit
2017-09-04 18:17 ` [dpdk-dev] [PATCH v6 4/5] igb_uio: release in exact reverse order Markus Theil
2017-09-04 18:17 ` [dpdk-dev] [PATCH v6 5/5] igb_uio: MSI IRQ mode, use kernel functions for masking MSI and MSI-X Markus Theil
2017-09-04 21:38 ` Ferruh Yigit
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 1/6] igb_uio: refactor irq enable/disable into own functions Markus Theil
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 2/6] igb_uio: fix irq disable on recent kernels Markus Theil
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function Markus Theil
2017-09-11 17:56 ` Ferruh Yigit
2017-09-11 22:04 ` Stephen Hemminger
2017-09-12 8:14 ` Bruce Richardson
2017-09-12 15:01 ` Stephen Hemminger
2017-09-12 8:16 ` Bruce Richardson
2017-09-12 16:31 ` Kevin Traynor
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 4/6] igb_uio: release in exact reverse order Markus Theil
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X Markus Theil
2017-10-09 21:56 ` Patrick MacArthur
2017-10-12 17:04 ` Ferruh Yigit
2017-10-13 2:49 ` Ferruh Yigit
2017-10-13 8:28 ` Kavanagh, Mark B
2017-10-12 10:50 ` Kavanagh, Mark B
2017-10-12 20:58 ` Ferruh Yigit
2017-10-12 21:15 ` Stephen Hemminger
2017-10-13 0:28 ` Ferruh Yigit
2017-09-05 12:04 ` [dpdk-dev] [PATCH v7 6/6] igb_uio: MSI IRQ mode Markus Theil
2017-09-11 17:48 ` [dpdk-dev] [PATCH v7 1/6] igb_uio: refactor irq enable/disable into own functions Ferruh Yigit
2017-09-14 12:04 ` Markus Theil
2017-10-06 22:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bfac191-103f-54c8-3ffc-f094ec6f8f44@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=nicolas.dichtel@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).