From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots
Date: Wed, 7 Jun 2017 18:20:43 +0100 [thread overview]
Message-ID: <4ca53d20-a36a-f769-fefe-1619bd1a36af@intel.com> (raw)
In-Reply-To: <1494503486-20876-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com>
On 5/11/2017 12:51 PM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf
> always into alloc_q, which is excessively leading too many rte_pktmbuf_
> free() when alloc_q is contending at high packet rate (for eg 10Gig data).
> In a situation when alloc_q fifo can only accommodate very few (or zero)
> mbuf, create only what needed and add in fifo.
>
> With this patch, we could stop random network stall in KNI at higher packet
> rate (eg 1G or 10G data between vEth0 and PMD) sufficiently exhausting
> alloc_q on above condition. I tested i40e PMD for this purpose in ppc64le.
>
> Changes:
> v2 - alloc_q free count calculation corrected.
> line wrap fixed for commit message.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2017-06-07 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 11:29 [dpdk-dev] [PATCH] " Gowrishankar
2017-05-11 11:51 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2017-05-16 17:15 ` Ferruh Yigit
2017-05-18 17:45 ` gowrishankar muthukrishnan
2017-05-31 16:21 ` Ferruh Yigit
2017-06-01 5:56 ` gowrishankar muthukrishnan
2017-06-01 9:18 ` Ferruh Yigit
2017-06-06 14:43 ` gowrishankar muthukrishnan
2017-06-07 17:20 ` Ferruh Yigit
2017-06-07 17:20 ` Ferruh Yigit [this message]
2017-07-01 10:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca53d20-a36a-f769-fefe-1619bd1a36af@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).