From: Guoyang Zhou <zhouguoyang@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "bluca@debian.org" <bluca@debian.org>,
"Wangxiaoyun (Cloud)" <cloud.wangxiaoyun@huawei.com>,
Luoxianjun <luoxianjun@huawei.com>,
"Yinshi (Stone)" <yin.yinshi@huawei.com>,
luojiachen <luojiachen@huawei.com>,
"Chenlizhong (IT Chip)" <chenlizhong@huawei.com>,
"Zhaohui (zhaohui,
Cloud Infrastructure Service Product Dept.)"
<zhaohui8@huawei.com>, chenchanghu <chenchanghu@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v1 0/2] remove some limitations and operations
Date: Wed, 25 Nov 2020 12:02:04 +0800 [thread overview]
Message-ID: <4d201ad2-14e8-e529-4f89-443fef2583dc@huawei.com> (raw)
In-Reply-To: <f21d0686-543e-b4d2-5e43-8c76a3a719f3@intel.com>
Hi ferruh,
I hope that these two patches can be applied.
Because in that way, the version can be stable.
Thanks,
Guoyang zhou
在 2020/11/24 17:31, Ferruh Yigit 写道:
> On 11/23/2020 4:09 PM, Ferruh Yigit wrote:
>> On 11/23/2020 1:12 PM, Guoyang Zhou wrote:
>>> The maximum number of queues on the chip can be any value greater
>>> than 0, it does not have to be the power of two, and remove the
>>> operation of optical modules in the link function.
>>>
>>> --
>>> v1:
>>> - remove the limitation for max queue num
>>> - remove the operation of optical modules in the link function
>>>
>>> Guoyang Zhou (2):
>>> net/hinic/base: remove the limitation for max queue num
>>> net/hinic: remove the operation of optical modules
>>>
>>
>> Hi Guoyang,
>>
>> How critical is this set, can you please describe the impact of the fixes?
>>
>> If they are not critical, let's postpone them to next release, since the release
>> is a few days away.
>>
>
> Hi Guoyang,
>
> I can see that a v2 has been sent but it is still not clear if you are OK to
> defer the patches, can you please share your thoughts on it?
>
> Thanks,
> ferruh
>
>> btw, both patches has [1] as a fixed patch, but that patch looks unrelated with
>> both, that patch only cleans up the uninit/destroy path.
>> Can you please elaborate why that patch is fixed?
>>
>> As far as I can see the condition removed in first patch introduced in v19.08
>> ([2]) and the calls in second patch added in v19.11 ([3]).
>>
>>
>>
>> [1]
>> Fixes: 511b7371d32b ("net/hinic: fix hugepage memory leaks")
>>
>>
>> [2]
>> Fixes: 828d3e15a9dc ("net/hinic/base: support context and work queue")
>>
>> [3]
>> Fixes: 54ac33869932 ("net/hinic: set link down and up")
>
prev parent reply other threads:[~2020-11-25 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:12 Guoyang Zhou
2020-11-23 13:12 ` [dpdk-dev] [PATCH v1 1/2] net/hinic/base: remove the limitation for max queue num Guoyang Zhou
2020-11-23 13:12 ` [dpdk-dev] [PATCH v1 2/2] net/hinic: remove the operation of optical modules Guoyang Zhou
2020-11-23 16:09 ` [dpdk-dev] [PATCH v1 0/2] remove some limitations and operations Ferruh Yigit
2020-11-24 9:31 ` Ferruh Yigit
2020-11-25 4:02 ` Guoyang Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d201ad2-14e8-e529-4f89-443fef2583dc@huawei.com \
--to=zhouguoyang@huawei.com \
--cc=arybchenko@solarflare.com \
--cc=bluca@debian.org \
--cc=chenchanghu@huawei.com \
--cc=chenlizhong@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=luojiachen@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=thomas@monjalon.net \
--cc=yin.yinshi@huawei.com \
--cc=zhaohui8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).