From: "Jiang, YuX" <yux.jiang@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>,
"Fu, Patrick" <patrick.fu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Jiang, YuX" <yux.jiang@intel.com>,
"Zhang, XiX" <xix.zhang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails
Date: Tue, 20 Oct 2020 08:43:08 +0000 [thread overview]
Message-ID: <4d29d46c322d48c59ec7c167e76cb38f@intel.com> (raw)
In-Reply-To: <20201020071628.323641-1-amorenoz@redhat.com>
Tested-by: JiangYuX <yux.jiang@intel.com>
Best Regards
Jiang yu
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrian Moreno
> Sent: Tuesday, October 20, 2020 3:16 PM
> To: dev@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Fu, Patrick
> <patrick.fu@intel.com>; amorenoz@redhat.com; stable@dpdk.org; Maxime
> Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails
>
> If stat fails it means the backend must be vhost-user in server mode
>
> Bugzilla ID: 559
> Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> ---
> drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> index 042665bc0..ce74d08ab 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -560,9 +560,10 @@ virtio_user_backend_type(const char *path)
> struct stat sb;
>
> if (stat(path, &sb) == -1) {
> - PMD_INIT_LOG(ERR, "Stat fails: %s (%s)\n", path,
> + PMD_INIT_LOG(INFO, "Stat fails: %s (%s)\n", path,
> strerror(errno));
> - return VIRTIO_USER_BACKEND_UNKNOWN;
> + /* Must be vhost-user in server mode */
> + return VIRTIO_USER_BACKEND_VHOST_USER;
> }
>
> if (S_ISSOCK(sb.st_mode)) {
> --
> 2.26.2
next prev parent reply other threads:[~2020-10-20 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:16 [dpdk-stable] " Adrian Moreno
2020-10-20 8:43 ` Jiang, YuX [this message]
2020-10-20 9:01 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-10-20 9:11 ` Maxime Coquelin
2020-10-20 9:38 ` Kevin Traynor
2020-10-20 9:55 ` Maxime Coquelin
2020-10-20 10:33 ` Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d29d46c322d48c59ec7c167e76cb38f@intel.com \
--to=yux.jiang@intel.com \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=stable@dpdk.org \
--cc=xix.zhang@intel.com \
--cc=yinan.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).