From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag of ports enumeration
Date: Tue, 24 Apr 2018 19:16:11 +0100 [thread overview]
Message-ID: <4d7429e7-90a7-222e-e818-3c50d6ff3571@intel.com> (raw)
In-Reply-To: <20180424021511.17430-1-thomas@monjalon.net>
On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> The basic operations for ports enumeration should not be
> considered as experimental in DPDK 18.05.
>
> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> It uses the function the rte_eth_find_next_owned_by() to get
> only ownerless ports. Its API can be considered stable.
> So the flag experimental is removed from rte_eth_find_next_owned_by().
>
> The flag experimental is removed from rte_eth_dev_count_avail()
> which is the new name of the old function rte_eth_dev_count().
>
> The flag experimental is set to rte_eth_dev_count_total()
> in the .c file for consistency with the declaration in the .h file.
>
> A lot of internal applications are fixed to not allow experimental API.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: d9a42a69febf ("ethdev: deprecate port count function")
> Fixes: e70e26861eaf ("net/mvpp2: fix build")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> It was a really bad idea to keep the iterator macro and function
> as experimental.
> And it was a real mistake of setting the new name of rte_eth_dev_count
> function as experimental.
>
> I think this fix must be merged in 18.05-rc1, in order to avoid
> troubles when testing coming RC1.
Agree that these are very common functions and setting them experimental will
cause almost all application allow experimental which will weaken the value of
allow_experimental flag by hiding other experimental APIs because of these.
+1 to having this change for -rc1.
next prev parent reply other threads:[~2018-04-24 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 2:15 Thomas Monjalon
2018-04-24 11:59 ` David Marchand
2018-04-25 11:11 ` Ferruh Yigit
2018-04-24 18:16 ` Ferruh Yigit [this message]
2018-04-25 10:21 ` Ferruh Yigit
2018-04-25 10:29 ` Thomas Monjalon
2018-04-25 10:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d7429e7-90a7-222e-e818-3c50d6ff3571@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).