From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>, Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list
Date: Tue, 19 Sep 2017 12:00:05 +0100 [thread overview]
Message-ID: <4dd479dc-8d1e-7e6c-6100-7c71058d98b7@intel.com> (raw)
In-Reply-To: <DB6PR0502MB304888185A291EE64F4C5375D2600@DB6PR0502MB3048.eurprd05.prod.outlook.com>
On 9/19/2017 11:04 AM, Matan Azrad wrote:
>
> Hi Ferruh
>
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Tuesday, September 19, 2017 12:27 PM
>> To: Matan Azrad <matan@mellanox.com>; Gaetan Rivet
>> <gaetan.rivet@6wind.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list
>>
>> On 9/14/2017 4:32 PM, Matan Azrad wrote:
>>> Add supported failsafe features to feature list.
>>> Remove stats per queue feature from failsafe feature list since
>>> queue_stats_mapping_set dev op has not implemented yet.
>>>
>>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>>> ---
>>> doc/guides/nics/features/failsafe.ini | 15 ++++++++++++++-
>>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/doc/guides/nics/features/failsafe.ini
>>> b/doc/guides/nics/features/failsafe.ini
>>> index a42e344..9f48455 100644
>>> --- a/doc/guides/nics/features/failsafe.ini
>>> +++ b/doc/guides/nics/features/failsafe.ini
>>> @@ -4,20 +4,33 @@
>>> ; Refer to default.ini for the full list of available PMD features.
>>> ;
>>> [Features]
>>> +Speed capabilities = Y
>>> Link status = Y
>>> Link status event = Y
>>> MTU update = Y
>>> Jumbo frame = Y
>>> +Scattered Rx = Y
>>> +LRO = Y
>>> +TSO = Y
>>> Promiscuous mode = Y
>>> Allmulticast mode = Y
>>> Unicast MAC filter = Y
>>> Multicast MAC filter = Y
>>> VLAN filter = Y
>>> +Ethertype filter = Y
>>> +N-tuple filter = Y
>>> +SYN filter = Y
>>> +Tunnel filter = Y
>>> +Flexible filter = Y
>>> +Hash filter = Y
>>> +Flow director = Y
>>> Flow control = Y
>>> Flow API = Y
>>> +QinQ offload = Y
>>> +L3 checksum offload = Y
>>> +L4 checksum offload = Y
>>> Packet type parsing = Y
>>> Basic stats = Y
>>> -Stats per queue = Y
>>> ARMv7 = Y
>>> ARMv8 = Y
>>> Power8 = Y
>>
>> I am not sure if claiming support for these features is correct.
>> Failsafe itself doesn't provide these features, but relies underlying hardware
>> which we don't really know what they supports or not in this stage.
>>
>
> Don't you think that almost all failsafe features rely underlying hardware or sub PMDs?
You are right, perhaps we should remove all. This is helpful to show
what device features are supported. For failsafe, is this information
useful?
>
>> OK for dropping "Stats per queue"
>>
>>>
>
next prev parent reply other threads:[~2017-09-19 11:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 15:32 Matan Azrad
2017-09-18 13:51 ` Mcnamara, John
2017-09-19 9:27 ` Ferruh Yigit
2017-09-19 10:04 ` Matan Azrad
2017-09-19 11:00 ` Ferruh Yigit [this message]
2017-09-19 11:39 ` Matan Azrad
2017-09-22 10:32 ` Ferruh Yigit
2017-09-24 5:55 ` Matan Azrad
2017-10-25 18:44 ` Ferruh Yigit
2017-10-25 22:55 ` Gaëtan Rivet
2017-11-01 22:33 ` Ferruh Yigit
2017-11-02 5:53 ` Matan Azrad
2017-11-02 17:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd479dc-8d1e-7e6c-6100-7c71058d98b7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=john.mcnamara@intel.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).