DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>, dev@dpdk.org
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>,
	Helin Zhang <helin.zhang@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>,
	Pradeep <pradeep@us.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v4] i40e: implement vector PMD for altivec
Date: Thu, 23 Feb 2017 10:47:08 +0000	[thread overview]
Message-ID: <4e0b3481-cc3f-fe2a-1b51-239a1282d392@intel.com> (raw)
In-Reply-To: <e7e627fcac568d2743d3dd3baea2e473782efe6b.1487824425.git.gowrishankar.m@linux.vnet.ibm.com>

On 2/23/2017 4:39 AM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> 
> This patch enables i40e driver in powerpc along with its altivec
> intrinsic support.
> 
> Changes:
> v4 - docs and config update.
> v3 - minor corrections for coding style standard.
> v2 - minor corrections for gcc strict aliasing and coding style standard.
> 
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> ---
>  MAINTAINERS                                 |   1 +
>  config/defconfig_ppc_64-power8-linuxapp-gcc |   1 -
>  doc/guides/nics/features/i40e.ini           |   1 +
>  doc/guides/nics/features/i40e_vec.ini       |   1 +
>  doc/guides/rel_notes/release_17_05.rst      |   3 +
>  drivers/net/i40e/Makefile                   |   2 +
>  drivers/net/i40e/i40e_rxtx_vec_altivec.c    | 654 ++++++++++++++++++++++++++++
>  7 files changed, 662 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/i40e/i40e_rxtx_vec_altivec.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 24e0eff..8da7573 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -166,6 +166,7 @@ IBM POWER
>  M: Chao Zhu <chaozhu@linux.vnet.ibm.com>
>  F: lib/librte_eal/common/arch/ppc_64/
>  F: lib/librte_eal/common/include/arch/ppc_64/
> +F: drivers/net/i40e/i40e_rxtx_vec_altivec.c

Overall patch looks good to me, I would get it.

But this patch adds a new responsibility to "Chao Zhu", I believe this
requires an explicit ACK from him.

Thanks,
ferruh

  reply	other threads:[~2017-02-23 10:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 15:33 [dpdk-dev] [PATCH] " Gowrishankar
2017-02-20 11:41 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2017-02-20 11:52   ` Ferruh Yigit
2017-02-20 12:15 ` [dpdk-dev] [PATCH v3] " Gowrishankar
2017-02-22 17:35   ` Ferruh Yigit
2017-02-23  4:39 ` [dpdk-dev] [PATCH v4] " Gowrishankar
2017-02-23 10:47   ` Ferruh Yigit [this message]
2017-02-28  3:46   ` Chao Zhu
2017-03-02 12:10     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e0b3481-cc3f-fe2a-1b51-239a1282d392@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=gowrishankar.m@linux.vnet.ibm.com \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=pradeep@us.ibm.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).