From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: Akhil Goyal <gakhil@marvell.com>
Cc: Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Tejasree Kondoj" <ktejasree@marvell.com>
Subject: Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16
Date: Wed, 1 Feb 2023 14:37:45 +0000 [thread overview]
Message-ID: <4ea9ff4b-a968-ad9e-ba6b-d96755ed2480@intel.com> (raw)
In-Reply-To: <CO6PR18MB44841C5C4C9FD427C709FF19D8D19@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi
On 2/1/2023 2:16 PM, Akhil Goyal wrote:
> Hi Radu,
>
>> Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16
>>
>> Set AES-CTR IV length as 16 instead of taking from
>> SA config option since the application populates
>> 16B IV in the datapath. AES-CTR requires 16B IV
>> constructed from nonce and counter.
>>
>> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Do you have a comment on this?
No real objection, only that there is already an inconsistency in the
definitions of the aes-xxx-ctr entries, 128 bit IV is 8 bytes, 192 and
256 are 16 bytes. Maybe it would be better to change the 128 bit variant
definition? In any case:
Reviewed-by: Radu Nicolau <radu.nicolau@intel.com>
next prev parent reply other threads:[~2023-02-01 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 3:58 [PATCH] " Tejasree Kondoj
2022-12-15 5:42 ` [PATCH v2] " Tejasree Kondoj
2023-02-01 14:16 ` Akhil Goyal
2023-02-01 14:37 ` Nicolau, Radu [this message]
2023-02-21 16:37 ` [EXT] " Tejasree Kondoj
2023-02-22 9:56 ` Nicolau, Radu
2023-02-22 13:43 ` Akhil Goyal
2023-02-23 15:43 ` [PATCH v3] " Tejasree Kondoj
2023-02-27 17:45 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea9ff4b-a968-ad9e-ba6b-d96755ed2480@intel.com \
--to=radu.nicolau@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).