From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Pankaj Gupta <pagupta@vmware.com>,
jbehrens@vmware.com, yongwang@vmware.com
Cc: dev@dpdk.org
Subject: Re: [PATCH 5/8] vmxnet3, version 6
Date: Wed, 4 May 2022 17:46:50 +0300 [thread overview]
Message-ID: <4ece5c47-4f95-a803-e361-98fbab2b9ac9@oktetlabs.ru> (raw)
In-Reply-To: <20220503042257.15626-6-pagupta@vmware.com>
Summary should say what is done. Consider:
net/vmxnet3: support virtual HW version 6
On 5/3/22 07:22, Pankaj Gupta wrote:
> vmxnet3 version 6 supports some new features, including but
> not limited to:
> - Increased max MTU up to 9190
> - Increased max number of queues, both for RX and TX
RX -> Rx, TX -> Tx in accordnace with recommended spelling
> - Removes power-of-two limitations
> - Extended interrupt structures, required implementation for
> additional number of queues
Please, be consistent in tense used above, "increased" vs "removes".
> Tested, using testpmd, for different hardware version on
> ESXi 7.0 Update 2.
>
> Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
> ---
> drivers/net/vmxnet3/base/vmxnet3_defs.h | 135 +++++++++-----
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 223 +++++++++++++++++-------
> drivers/net/vmxnet3/vmxnet3_ethdev.h | 10 +-
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-
> 4 files changed, 260 insertions(+), 110 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h
> index 8d62b3e116..ceac5d64db 100644
> --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
> +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
> @@ -72,38 +72,42 @@
> #endif
>
> typedef enum {
> - VMXNET3_CMD_FIRST_SET = 0xCAFE0000,
> - VMXNET3_CMD_ACTIVATE_DEV = VMXNET3_CMD_FIRST_SET,
> - VMXNET3_CMD_QUIESCE_DEV,
> - VMXNET3_CMD_RESET_DEV,
> - VMXNET3_CMD_UPDATE_RX_MODE,
> - VMXNET3_CMD_UPDATE_MAC_FILTERS,
> - VMXNET3_CMD_UPDATE_VLAN_FILTERS,
> - VMXNET3_CMD_UPDATE_RSSIDT,
> - VMXNET3_CMD_UPDATE_IML,
> - VMXNET3_CMD_UPDATE_PMCFG,
> - VMXNET3_CMD_UPDATE_FEATURE,
> - VMXNET3_CMD_STOP_EMULATION,
> - VMXNET3_CMD_LOAD_PLUGIN,
> - VMXNET3_CMD_ACTIVATE_VF,
> - VMXNET3_CMD_RESERVED3,
> - VMXNET3_CMD_RESERVED4,
> - VMXNET3_CMD_REGISTER_MEMREGS,
> - VMXNET3_CMD_SET_RSS_FIELDS,
> -
> - VMXNET3_CMD_FIRST_GET = 0xF00D0000,
> - VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET,
> - VMXNET3_CMD_GET_STATS,
> - VMXNET3_CMD_GET_LINK,
> - VMXNET3_CMD_GET_PERM_MAC_LO,
> - VMXNET3_CMD_GET_PERM_MAC_HI,
> - VMXNET3_CMD_GET_DID_LO,
> - VMXNET3_CMD_GET_DID_HI,
> - VMXNET3_CMD_GET_DEV_EXTRA_INFO,
> - VMXNET3_CMD_GET_CONF_INTR,
> - VMXNET3_CMD_GET_ADAPTIVE_RING_INFO,
> - VMXNET3_CMD_GET_TXDATA_DESC_SIZE,
> - VMXNET3_CMD_RESERVED5,
> + VMXNET3_CMD_FIRST_SET = 0xCAFE0000,
> + VMXNET3_CMD_ACTIVATE_DEV = VMXNET3_CMD_FIRST_SET,
> + VMXNET3_CMD_QUIESCE_DEV,
> + VMXNET3_CMD_RESET_DEV,
> + VMXNET3_CMD_UPDATE_RX_MODE,
> + VMXNET3_CMD_UPDATE_MAC_FILTERS,
> + VMXNET3_CMD_UPDATE_VLAN_FILTERS,
> + VMXNET3_CMD_UPDATE_RSSIDT,
> + VMXNET3_CMD_UPDATE_IML,
> + VMXNET3_CMD_UPDATE_PMCFG,
> + VMXNET3_CMD_UPDATE_FEATURE,
> + VMXNET3_CMD_STOP_EMULATION,
> + VMXNET3_CMD_LOAD_PLUGIN,
> + VMXNET3_CMD_ACTIVATE_VF,
> + VMXNET3_CMD_RESERVED3,
> + VMXNET3_CMD_RESERVED4,
> + VMXNET3_CMD_REGISTER_MEMREGS,
> + VMXNET3_CMD_SET_RSS_FIELDS,
> +
> + VMXNET3_CMD_FIRST_GET = 0xF00D0000,
> + VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET,
> + VMXNET3_CMD_GET_STATS,
> + VMXNET3_CMD_GET_LINK,
> + VMXNET3_CMD_GET_PERM_MAC_LO,
> + VMXNET3_CMD_GET_PERM_MAC_HI,
> + VMXNET3_CMD_GET_DID_LO,
> + VMXNET3_CMD_GET_DID_HI,
> + VMXNET3_CMD_GET_DEV_EXTRA_INFO,
> + VMXNET3_CMD_GET_CONF_INTR,
> + VMXNET3_CMD_GET_ADAPTIVE_RING_INFO,
> + VMXNET3_CMD_GET_TXDATA_DESC_SIZE,
> + VMXNET3_CMD_RESERVED5,
> + VMXNET3_CMD_RESERVED6,
> + VMXNET3_CMD_RESERVED7,
> + VMXNET3_CMD_RESERVED8,
> + VMXNET3_CMD_GET_MAX_QUEUES_CONF,
It is hard to find what is really done above. If you wnat to fix an
alignment, please, do it in a separate prepatch without any real
changes.
> } Vmxnet3_Cmd;
>
> /* Adaptive Ring Info Flags */
> @@ -571,6 +575,24 @@ enum vmxnet3_intr_type {
> /* addition 1 for events */
> #define VMXNET3_MAX_INTRS 25
>
> +/* Version 6 and later will use below macros */
> +#define VMXNET3_EXT_MAX_TX_QUEUES 32
> +#define VMXNET3_EXT_MAX_RX_QUEUES 32
> +
> +/* Version-dependent MAX RX/TX queues macro */
> +#define MAX_RX_QUEUES \
> + (VMXNET3_VERSION_GE_6(hw) ? \
I think it is beter to pass 'hw' argument explicintly.
Otherwise it looks inconsistent and confusing.
> + VMXNET3_EXT_MAX_RX_QUEUES : \
> + VMXNET3_MAX_RX_QUEUES)
> +#define MAX_TX_QUEUES \
> + (VMXNET3_VERSION_GE_6(hw) ? \
same here
> + VMXNET3_EXT_MAX_TX_QUEUES : \
> + VMXNET3_MAX_TX_QUEUES)
> +
[snip]
next prev parent reply other threads:[~2022-05-04 14:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 4:22 [PATCH 0/8] vmxnet3 version V5 and V6 Pankaj Gupta
2022-05-03 4:22 ` [PATCH 1/8] vmxnet3: Added V5 support Pankaj Gupta
2022-05-03 4:22 ` [PATCH 2/8] vmxnet3: implement reta query and reta update Pankaj Gupta
2022-05-04 14:23 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 3/8] vmxnet3: add rx queue usage count utility Pankaj Gupta
2022-05-04 14:27 ` Andrew Rybchenko
2022-05-04 14:35 ` Morten Brørup
2022-05-04 17:58 ` Pankaj Gupta
2022-05-03 4:22 ` [PATCH 4/8] vmxnet3: add get hw version api Pankaj Gupta
2022-05-04 14:35 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 5/8] vmxnet3, version 6 Pankaj Gupta
2022-05-04 14:46 ` Andrew Rybchenko [this message]
2022-05-03 4:22 ` [PATCH 6/8] vmxnet3: set reta size Pankaj Gupta
2022-05-04 15:05 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 7/8] vmxnet3: Set packet for fragmented packet Pankaj Gupta
2022-05-04 15:07 ` Andrew Rybchenko
2022-05-04 20:40 ` Pankaj Gupta
2022-05-05 8:45 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature Pankaj Gupta
2022-05-04 15:09 ` Andrew Rybchenko
2022-05-04 20:37 ` Pankaj Gupta
2022-05-05 8:37 ` Andrew Rybchenko
2022-05-03 18:50 ` [PATCH 0/8] vmxnet3 version V5 and V6 Jochen Behrens
2022-05-04 14:28 ` Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 1/9] net/vmxnet3: add version 5 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 5/9] net/vmxnet3: report HW version on FW version get Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 6/9] net/vmxnet3: add version 6 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization Andrew Rybchenko
2022-05-19 8:07 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-23 20:56 ` Pankaj Gupta
2022-05-24 6:46 ` Andrew Rybchenko
-- strict thread matches above, loose matches on Subject: below --
2022-05-02 19:45 [PATCH 0/8] vmxnet3: V5 and V6 Pankaj Gupta
2022-05-02 19:45 ` [PATCH 5/8] vmxnet3, version 6 Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ece5c47-4f95-a803-e361-98fbab2b9ac9@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jbehrens@vmware.com \
--cc=pagupta@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).