From: Declan Doherty <declan.doherty@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout
Date: Tue, 10 Jan 2017 10:41:51 +0000 [thread overview]
Message-ID: <4f4e8f46-2be6-aef5-e539-5ccd9b2c9097@intel.com> (raw)
In-Reply-To: <2615371.2k6WulVlxV@xps13>
On 05/01/17 15:40, Thomas Monjalon wrote:
> 2017-01-05 17:49, Slawomir Mrozowicz:
>> Add EAL option to suppresses all log output to stdout.
>>
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> [...]
>> " --"OPT_LOG_LEVEL" Set default log level\n"
>> + " -s, --"OPT_LOG_STDOUT_SILENT" Silent mode, suppresses log "
>> + "output to stdout\n"
>
> How does it behave when the app configure a custom log function which
> prints to stdout?
>
> Generally speaking, we should stop adding such options in DPDK and
> move this kind of responsibility to the applications (providing some API
> and helpers).
>
Hey Thomas,
this option wouldn't affect a custom log function as the flag this
controls is only used within by the default Linux log file stream in the
console_log_write function. Maybe a better option would be to change the
general behaviour of the default logging function and remove the printf
to stdout completely and add a generic verbose option applicable to all
environments which would allow log output to be directed to stdout. I
did notice that the default behaviour between Linux/BSD does seem to be
different with Linux defaulting to syslog/stdout and BSD to stderr.
One way or another I would like to able to disable streaming of log
output to stdout when using the default log stream in Linux, but I'm
open to suggestions as to the best way of doing this?
next prev parent reply other threads:[~2017-01-10 10:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:15 [dpdk-dev] [PATCH 0/2] Introduce new performance test application Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 1/2] lib/librte_cryptodev: functions for " Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 2/2] app/crypto-perf: Introduce " Michal Jastrzebski
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 0/4] " Slawomir Mrozowicz
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout Slawomir Mrozowicz
2017-01-05 15:40 ` Thomas Monjalon
2017-01-10 10:41 ` Declan Doherty [this message]
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application Slawomir Mrozowicz
2017-01-06 12:21 ` De Lara Guarch, Pablo
2017-01-09 9:11 ` Mrozowicz, SlawomirX
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce " Slawomir Mrozowicz
2017-01-09 14:51 ` De Lara Guarch, Pablo
2017-01-10 7:28 ` Mrozowicz, SlawomirX
2017-01-09 15:24 ` Thomas Monjalon
2017-01-10 8:52 ` Mrozowicz, SlawomirX
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 0/2] Introduce " Slawomir Mrozowicz
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 1/2] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-11 15:21 ` Trahe, Fiona
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 2/2] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 0/4] Introduce " Slawomir Mrozowicz
2017-01-25 15:59 ` De Lara Guarch, Pablo
2017-01-26 9:43 ` De Lara Guarch, Pablo
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 1/4] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 2/4] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 3/4] app/crypto-perf: add test vectors files Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application Slawomir Mrozowicz
2017-01-26 15:21 ` Ferruh Yigit
2017-01-26 15:23 ` Richardson, Bruce
2017-01-26 17:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4e8f46-2be6-aef5-e539-5ccd9b2c9097@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).