From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"ktraynor@redhat.com" <ktraynor@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default
Date: Tue, 7 Nov 2017 12:04:35 +0100 [thread overview]
Message-ID: <4fc9b3ec-836f-5a1c-1002-78e197161120@redhat.com> (raw)
In-Reply-To: <DC5AD7FA266D86499789B1BCAEC715F8D3A42A55@irsmsx105.ger.corp.intel.com>
Hi Mark,
On 11/07/2017 11:56 AM, Kavanagh, Mark B wrote:
>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
>> Sent: Monday, November 6, 2017 8:38 PM
>> To: dev@dpdk.org; yliu@fridaylinux.org; Kavanagh, Mark B
>> <mark.b.kavanagh@intel.com>; thomas@monjalon.net; ktraynor@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH v2 0/3] vhost: disable iommu support by default
>>
>> This series disables IOMMU feature by default, and introduce
>> a new flag passed at vhost device registration time to enable
>> it explicitly.
>>
>> When disabled, patch 1 also disables reply-ack protocol feature
>> to avoid Qemu v2.7.0-v2.9.0 reply-ack bug with multiqueue.
>>
>> Last patch adds a Vhost PMD "iommu-support" parameter to enable
>> the IOMMU feature.
>
> Hi Maxime,
>
> I'm happy to confirm that this patchset resolves the vhost user mutltiq issue for OvS-DPDK, with QEMU v2.7.1.
Thanks for the testing.
> Additionally, all of the individual patches look good - thanks for all of your efforts on this!
Great.
Now, what is required on OVS side is the introduction of a new vhost
port option to enable IOMMU support, so that management layer has a way
to enable it when VM has an iommu placed in front of the virtio device.
Note that OVS can set the flag even if no IOMMU is present, as Virtio
feature negotiation will manage this.
> Tested-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
> Acked-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Thanks,
Maxime
> Cheers,
> Mark
>
>>
>> Maxime Coquelin (3):
>> vhost: disable reply-ack protocol feature if iommu feature disabled
>> vhost: add flag to enable iommu support
>> net: vhost: add iommu-support parameter to enable IOMMU feature
>>
>> doc/guides/nics/vhost.rst | 5 +++++
>> doc/guides/prog_guide/vhost_lib.rst | 14 ++++++++++++++
>> doc/guides/rel_notes/release_17_11.rst | 3 ++-
>> drivers/net/vhost/rte_eth_vhost.c | 13 +++++++++++++
>> lib/librte_vhost/rte_vhost.h | 1 +
>> lib/librte_vhost/socket.c | 6 ++++++
>> lib/librte_vhost/vhost_user.c | 24 ++++++++++++++++++++++--
>> 7 files changed, 63 insertions(+), 3 deletions(-)
>>
>> --
>> 2.13.6
>
next prev parent reply other threads:[~2017-11-07 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 17:57 [dpdk-dev] [PATCH] vhost: disable reply-ack protocol feature if iommu feature disabled Maxime Coquelin
2017-11-06 14:22 ` Kavanagh, Mark B
2017-11-06 20:38 ` [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default Maxime Coquelin
2017-11-06 20:38 ` [dpdk-dev] [PATCH v2 1/3] vhost: disable reply-ack protocol feature if iommu feature disabled Maxime Coquelin
2017-11-06 20:38 ` [dpdk-dev] [PATCH v2 2/3] vhost: add flag to enable iommu support Maxime Coquelin
2017-11-06 20:38 ` [dpdk-dev] [PATCH v2 3/3] net: vhost: add iommu-support parameter to enable IOMMU feature Maxime Coquelin
2017-11-07 3:32 ` [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default Yuanhan Liu
2017-11-07 13:20 ` Thomas Monjalon
2017-11-07 10:56 ` Kavanagh, Mark B
2017-11-07 11:04 ` Maxime Coquelin [this message]
2017-11-07 11:08 ` Kavanagh, Mark B
2017-11-07 12:27 ` Maxime Coquelin
2017-11-07 11:25 ` Kevin Traynor
2017-11-07 11:30 ` Maxime Coquelin
2017-11-07 11:51 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fc9b3ec-836f-5a1c-1002-78e197161120@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=mark.b.kavanagh@intel.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).