From: Thomas Monjalon <thomas@monjalon.net>
To: Oleksandr Kolomeiets <okl-plv@napatech.com>
Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Mykola Kostenok <mko-plv@napatech.com>,
Christian Koue Muf <ckm@napatech.com>,
dev@dpdk.org,
"aman.deep.singh@intel.com" <aman.deep.singh@intel.com>,
"yuying.zhang@intel.com" <yuying.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>
Subject: Re: [PATCH v2] app/testpmd: support updating flow rule actions
Date: Wed, 21 Feb 2024 11:32:05 +0100 [thread overview]
Message-ID: <5040653.cLl3JjQhRp@thomas> (raw)
In-Reply-To: <AM9P190MB10575CDF082E473E92B1C90E9E482@AM9P190MB1057.EURP190.PROD.OUTLOOK.COM>
12/02/2024 09:37, Oleksandr Kolomeiets:
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 01/02/2024 10:59, Oleksandr Kolomeiets:
> > > > "flow actions_update" updates a flow rule specified by a rule ID with
> > > >
> > > > a new action list by making a call to "rte_flow_actions_update()":
> > > > flow actions_update {port_id} {rule_id}
> > > >
> > > > actions {action} [/ {action} [...]] / end [user_id]
> > > >
> > > > Creating, updating and destroying a flow rule:
> > > > testpmd> flow create 0 group 1 pattern eth / end actions drop /
> > > > end
> > > > Flow rule #0 created
> > > > testpmd> flow actions_update 0 0 actions queue index 1 / end
> > > > Flow rule #0 updated with new actions
> > > > testpmd> flow destroy 0 rule 0
> > > > Flow rule #0 destroyed
> > >
> > > Why not a simple "flow update" command name?
> >
> > +1. This would also make it consistent with async version of this command
> > - "flow queue {port_id} update ...".
>
> Indeed, shortening the command from "flow actions_update" to "flow update" seems more natural.
> However, note that the command updates only the actions of a flow rule and leaves all other parameters unchanged.
> My concern is that in the future there can be some "flow pattern_update" command, thus making "flow update" command ambiguous.
> Also, the name is consistent with the underlying rte_flow_actions_update() function.
> With that in mind, please clarify if the name should still be changed.
If a function is added for pattern update, we could still implement it
with the same command prefix "flow update" and call functions as appropriate.
So yes I still think the command should be "flow update".
next prev parent reply other threads:[~2024-02-21 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 13:21 [PATCH] " Oleksandr Kolomeiets
2024-02-01 9:59 ` [PATCH v2] " Oleksandr Kolomeiets
2024-02-02 9:55 ` Thomas Monjalon
2024-02-05 19:18 ` Dariusz Sosnowski
2024-02-12 8:37 ` Oleksandr Kolomeiets
2024-02-21 10:32 ` Thomas Monjalon [this message]
2024-02-22 9:04 ` [PATCH v3] " Oleksandr Kolomeiets
2024-02-23 4:19 ` [PATCH v4] " Oleksandr Kolomeiets
2024-02-28 17:33 ` Ferruh Yigit
2024-02-29 2:15 ` [PATCH v5] " Oleksandr Kolomeiets
2024-02-29 14:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040653.cLl3JjQhRp@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=ckm@napatech.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=mko-plv@napatech.com \
--cc=okl-plv@napatech.com \
--cc=orika@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).