DPDK patches and discussions
 help / color / mirror / Atom feed

From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: make commits with stable tag outstanding
Date: Fri, 10 Mar 2017 12:13:28 +0100	[thread overview]
Message-ID: <5048683.EcVWt1ukKe@xps13> (raw)
In-Reply-To: <1487818172-12910-1-git-send-email-yuanhan.liu@linux.intel.com>

2017-02-23 10:49, Yuanhan Liu:
> So that, as a stable maintainer while picking commits to a stable release,
> I could pay less attention to those have it and pay more attention to those
> don't have it.

Good idea 

> +	stable="-"
> +	git show $id | grep -qi 'Cc: .*stable@dpdk.org' && stable="S"

Instead of git show, it is preferrable to get only the message content:
	git log --format='%b' -1 $id

The regex may miss a Cc: without space, and may match a Cc in the middle
of a sentence.
I suggest this one:
	grep -qi '^Cc: *stable@dpdk.org'

The script is written in the style "set -e" so it must be avoided to have
a "false" statement not catched.
It can be done in 2 ways:

1/
git log --format='%b' -1 $id | grep -qi '^Cc: *stable@dpdk.org' && stable='S' || stable='-'

2/
if git log --format='%b' -1 $id | grep -qi '^Cc: *stable@dpdk.org' ; then
	stable='S'
else
	stable='-'
endif

We can also move it in a function in order to keep only the logic in the
"main" block:
	stable=$(stable_tag $id)

# print a marker for stable tag presence
stable_tag () # <hash>
{
	if git log --format='%b' -1 $id | grep -qi '^Cc: *stable@dpdk.org' ; then
		echo 'S'
	else
		echo '-'
	endif
}

next prev parent reply	other threads:[~2017-03-10 11:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  2:49 Yuanhan Liu
2017-03-10 11:13 ` Thomas Monjalon [this message]
2017-04-06  6:31   ` Yuanhan Liu
2017-04-06  6:33 ` [dpdk-dev] [PATCH v2] " Yuanhan Liu
2017-04-06 19:25   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5048683.EcVWt1ukKe@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).