From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void
Date: Tue, 06 Aug 2019 13:24:38 +0200 [thread overview]
Message-ID: <5059724.Axm0xEFYWp@xps> (raw)
In-Reply-To: <ce81b13d-6173-56df-a60b-9682119d48ab@intel.com>
23/07/2019 16:22, Ferruh Yigit:
> On 7/23/2019 3:07 PM, Andrew Rybchenko wrote:
> > void return value is bad for get API (like rte_eth_dev_info-get())
> > since caller does not know if the function does its job or not and
> > output value is filled in.
> >
> > void return value is bad for state changing API (like
> > rte_eth_promiscuous_enable()) since caller should use get API
> > to understand if state is really changed.
> >
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > ---
> > +* ethdev: update API functions returning ``void`` to return ``int`` with
> > + negative errno values to indicate various error conditions (e.g.
> > + invalid port ID, unsupported operation, failed operation):
> > +
> > + - ``rte_eth_dev_info_get``
> > + - ``rte_eth_promiscuous_enable`` and ``rte_eth_promiscuous_disable``
> > + - ``rte_eth_allmulticast_enable`` and ``rte_eth_allmulticast_disable``
> > + - ``rte_eth_link_get`` and ``rte_eth_link_get_nowait``
> > + - ``rte_eth_dev_stop``
> > + - ``rte_eth_dev_close``
> > + - ``rte_eth_xstats_reset``
> > + - ``rte_eth_macaddr_get``
> > + - ``rte_eth_dev_owner_delete``
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2019-08-06 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:07 Andrew Rybchenko
2019-07-23 14:22 ` Ferruh Yigit
2019-08-06 11:24 ` Thomas Monjalon [this message]
2019-08-10 20:29 ` Thomas Monjalon
2019-07-23 14:38 ` Stephen Hemminger
2019-07-23 14:52 ` Andrew Rybchenko
2019-07-24 9:17 ` Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059724.Axm0xEFYWp@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).