From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support
Date: Tue, 3 Apr 2018 13:54:15 +0100 [thread overview]
Message-ID: <50a3b667-aa12-28de-1998-6bd3492edbfb@intel.com> (raw)
In-Reply-To: <a366003f-4356-dc27-bfeb-0cbdbe50f447@intel.com>
On 4/3/2018 12:09 PM, Ferruh Yigit wrote:
> On 3/31/2018 6:04 PM, Alejandro Lucero wrote:
>>
>>
>> On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit <ferruh.yigit@intel.com
>> <mailto:ferruh.yigit@intel.com>> wrote:
>>
>> On 3/23/2018 5:35 PM, Alejandro Lucero wrote:
>> > CPP refers to the internal NFP Command Push Pull bus. This patch allows
>> > to create CPP commands from user space allowing to access any single
>> > part of the chip.
>> >
>> > This CPP interface is the base for having other functionalities like
>> > mutexes when accessing specific chip components, chip resources management,
>> > firmware upload or using the NSP, an embedded arm processor which can
>> > perform tasks on demand.
>> >
>> > NSP was the previous only way for doing things in the chip by the PMD,
>> > where a NSPU interface was used for commands like firmware upload or
>> > port link configuration. CPP interface supersedes NSPU, but it is still
>> > possible to use NSP through CPP.
>> >
>> > CPP interface adds a great flexibility for doing things like extended
>> > stats, firmware debugging or selecting properly the firmware file to
>> > upload.
>>
>> It can be good to announce this new feature in release notes, what do you think?
>>
>>
>> Uhmm, not sure about this. It is specific to the NFP PMD and I do not see it as
>> a new feature, at least DPDK users will not be aware of it.
>
> OK, if this internal and you think user won't be interested in this update.
>
>>
>>
>>
>> Also get some build errors [1], one is about zlib.h, normally we disable PMDs by
>> default with external dependencies, is nfp depends to libz with this patch?
>>
>>
>> I forgot to remove this reference. It is not needed now, but it was with the
>> initial internal work.
>>
>> About the other build errors, I do not get them and I have used a couple of
>> different systems, Ubuntu and Redhat. This is, of course, a serious concern. Can
>> you give me more information about the system you are using?
>>
>> I remember I got some build error with other patches, from automatic builds made
>> just after those patches were sent. I did not get any this time, just those
>> warning for checkpatch which I was aware of. Is this automatic build not
>> happening any more?
>
> I will share more details. Automatic build still works and it has wider
> coverage, this is from my local script...
[1] seems valid and for all.
[2] #include <zlib.h> seems for all.
[3] clang
[1]
...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readl’:
...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: ‘tmp’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
*value = rte_le_to_cpu_32(tmp);
...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readq’:
...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: ‘tmp’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
*value = rte_le_to_cpu_64(tmp);
[2]
...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: zlib.h: No
such file or directory
#include <zlib.h>
^~~~~~~~
compilation terminated.
make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:116: nfp_resource.o] Error 1
make[7]: *** Waiting for unfinished jobs....
...dpdk/drivers/net/nfp/nfpcore/nfp_hwinfo.c:47:10: fatal error: zlib.h: No such
file or directory
#include <zlib.h>
^~~~~~~~
[3]
...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format specifies type
'short' but the argument has type 'unsigned int' [-Werror,-Wformat]
printf("\tusage:%hd\n", mutex->usage);
~~~ ^~~~~~~~~~~~
%u
1 error generated.
make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:114: nfp_mutex.o] Error 1
make[7]: *** Waiting for unfinished jobs....
...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused function
'__nfp_bytemask_of' [-Werror,-Wunused-function]
__nfp_bytemask_of(int width, uint64_t addr)
^
1 error generated.
make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:114: nfp_cppcore.o] Error 1
...dpdk/drivers/net/nfp/nfp_net.c:2970:35: error: format specifies type
'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
[-Werror,-Wformat]
cpp->serial[4], cpp->serial[5], cpp->interface >> 8,
^~~~~~~~~~~~~~~~~~~
...dpdk/drivers/net/nfp/nfp_net.c:2971:3: error: format specifies type 'unsigned
char' but the argument has type 'unsigned int' [-Werror,-Wformat]
cpp->interface & 0xff);
^~~~~~~~~~~~~~~~~~~~~
2 errors generated.
>
>>
>>
>>
>> [1]
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format specifies type
>> 'short' but the argument has type 'unsigned int' [-Werror,-Wformat]
>> printf("\tusage:%hd\n", mutex->usage);
>>
>> ~~~ ^~~~~~~~~~~~
>>
>>
>> %u
>>
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused function
>> '__nfp_bytemask_of' [-Werror,-Wunused-function]
>> __nfp_bytemask_of(int width, uint64_t addr)
>>
>>
>> ^
>>
>> ...dpdk/drivers/net/nfp/nfp_net.c:2971:35: error: format specifies type
>> 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
>> [-Werror,-Wformat]
>> cpp->serial[4], cpp->serial[5], cpp->interface >> 8,
>>
>>
>> ^~~~~~~~~~~~~~~~~~~
>> ...dpdk/drivers/net/nfp/nfp_net.c:2972:3: error: format specifies type 'unsigned
>> char' but the argument has type 'unsigned int' [-Werror,-Wformat]
>> cpp->interface & 0xff);
>> ^~~~~~~~~~~~~~~~~~~~~
>>
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readl’:
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: ‘tmp’ may be used
>> uninitialized in this function [-Werror=maybe-uninitialized]
>> *value = rte_le_to_cpu_32(tmp);
>>
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readq’:
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: ‘tmp’ may be used
>> uninitialized in this function [-Werror=maybe-uninitialized]
>> *value = rte_le_to_cpu_64(tmp);
>>
>> ...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: zlib.h: No
>> such file or directory
>> #include <zlib.h>
>> ^~~~~~~~
>>
>> >
>> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com
>> <mailto:alejandro.lucero@netronome.com>>
>>
>> <...>
>>
>> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h
>> b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h
>> > new file mode 100644
>> > index 0000000..fbeec57
>> > --- /dev/null
>> > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h
>> > @@ -0,0 +1,748 @@
>> > +/*
>> > + * Copyright (c) 2018 Netronome Systems, Inc.
>> > + * All rights reserved.
>> > + *
>> > + * Redistribution and use in source and binary forms, with or without
>> > + * modification, are permitted provided that the following conditions are
>> met:
>> > + *
>> > + * 1. Redistributions of source code must retain the above copyright notice,
>> > + * this list of conditions and the following disclaimer.
>> > + *
>> > + * 2. Redistributions in binary form must reproduce the above copyright
>> > + * notice, this list of conditions and the following disclaimer in the
>> > + * documentation and/or other materials provided with the distribution
>> > + *
>> > + * 3. Neither the name of the copyright holder nor the names of its
>> > + * contributors may be used to endorse or promote products derived from this
>> > + * software without specific prior written permission.
>> > + *
>> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>> "AS IS"
>> > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>> > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>> > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
>> > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>> > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>> > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>> > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
>> > + * POSSIBILITY OF SUCH DAMAGE.
>> > + */
>>
>> Can you please add new files with SPDX tags?
>>
>>
>
next prev parent reply other threads:[~2018-04-03 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 17:35 [dpdk-dev] [PATCH 0/4] NFP PF support based on new CPP interface Alejandro Lucero
2018-03-23 17:35 ` [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support Alejandro Lucero
2018-03-30 10:37 ` Ferruh Yigit
2018-03-31 17:04 ` Alejandro Lucero
2018-04-03 11:09 ` Ferruh Yigit
2018-04-03 12:54 ` Ferruh Yigit [this message]
2018-03-23 17:35 ` [dpdk-dev] [PATCH 2/4] net/nfp: update PMD for using new CPP interface Alejandro Lucero
2018-03-23 17:35 ` [dpdk-dev] [PATCH 3/4] doc: update NFP guide Alejandro Lucero
2018-03-30 10:37 ` Ferruh Yigit
2018-03-31 17:04 ` Alejandro Lucero
2018-03-23 17:35 ` [dpdk-dev] [PATCH 4/4] net/nfp: remove files Alejandro Lucero
2018-04-05 14:28 [dpdk-dev] [PATCH v2 0/4] NFP PF support based on new CPP interface Alejandro Lucero
2018-04-05 14:28 ` [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50a3b667-aa12-28de-1998-6bd3492edbfb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).