From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org, Chas Williams <chas3@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter
Date: Mon, 25 Sep 2017 10:53:48 +0100 [thread overview]
Message-ID: <510427f2-5761-024f-791a-7d44c58231c9@intel.com> (raw)
In-Reply-To: <20170925094053.GA14012@bricha3-MOBL3.ger.corp.intel.com>
On 9/25/2017 10:40 AM, Bruce Richardson wrote:
> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote:
>> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote:
>>> Failure happens on build using:
>>> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)
>>
>> Yes, that case is missed. What do you think about following one:
>>
>> @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
>> unsigned int blockcnt,
>> unsigned int framesize,
>> unsigned int framecnt,
>> - unsigned int qdisc_bypass,
>> + unsigned int qdisc_bypass __rte_unused,
>> struct pmd_internals **internals,
>> struct rte_eth_dev **eth_dev,
>> struct rte_kvargs *kvlist)
>>
>>>
>>> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable")
>>>
>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>> ---
>>> May be the right solution in fact remove PACKET_QDISC_BYPASS conditional
>>> completely. If below solution is accepted, feel free to squash it into
>>> the original patch.
>>
>> It is a little to late for this, I already sent a pull-request with this
>> patch. So fix will need to be a separate patch.
>>
> Pull request hasn't actually been pulled yet, so you should be able to
> supercede it by a later one, right?
Technically yes, and easy to do, but it will be confusing. I was taking
pull-request as code freeze in sub-tree.
If there are multiple pull-request for a tree, how can one be sure which
ones has been pulled and what to expect in main repo, and verify what
has been merged?
As above said, if Thomas thinks this is OK, I can send another pull request?
next prev parent reply other threads:[~2017-09-25 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:50 Andrew Rybchenko
2017-09-25 8:42 ` Ferruh Yigit
2017-09-25 9:04 ` Andrew Rybchenko
2017-09-25 9:40 ` Bruce Richardson
2017-09-25 9:53 ` Ferruh Yigit [this message]
2017-09-25 10:06 ` Ferruh Yigit
2017-09-25 12:49 ` Ferruh Yigit
2017-09-25 14:24 ` Thomas Monjalon
2017-09-25 12:52 ` Ferruh Yigit
2017-09-25 12:53 ` Ferruh Yigit
2017-10-05 18:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510427f2-5761-024f-791a-7d44c58231c9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).