From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: fix relpath.sh output when $prefix is set in environment
Date: Fri, 11 Dec 2015 14:04:01 +0100 [thread overview]
Message-ID: <5188347.04ruq6Yd6l@xps13> (raw)
In-Reply-To: <37b46e91bdb51e6116df9a7edc2eb79206237f1c.1449837863.git.pmatilai@redhat.com>
2015-12-11 14:44, Panu Matilainen:
> When relpath.sh is called from install target with prefix set, eg
> "make install DESTDIR=/tmp/dpdk-root prefix=/usr", the prefix
> from the environment leaks to relpath.sh internal helper variable and
> causes incorrect symlinks to be generated in sdk $(targetdir):
>
> include -> /usr../../../include/dpdk
> lib -> /usr../../../lib
>
> Initialize the local variable to empty to avoid side-effects from
> environment.
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Good catch!
Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree")
Applied, thanks
prev parent reply other threads:[~2015-12-11 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 12:44 Panu Matilainen
2015-12-11 13:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188347.04ruq6Yd6l@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).