From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] bus/pci: check IO permissions for UIO only
Date: Thu, 24 Oct 2019 11:55:33 +0200 [thread overview]
Message-ID: <521000af-998e-cffd-4a0a-8db4eb9b3ba0@redhat.com> (raw)
In-Reply-To: <1571732503-30424-2-git-send-email-david.marchand@redhat.com>
On 10/22/19 10:21 AM, David Marchand wrote:
> On x86, calling inb/outb special instructions (used in UIO ioport
> read/write parts) is only possible if the right IO permissions has been
> granted.
>
> The only user of this API (the net/virtio pmd) checks this
> unconditionnaly but this should be hidden by the rte_pci_ioport API
> itself and only checked when the device is bound to a UIO driver.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v2:
> - do not switch to pci_ioport_map in igb_uio case, add a check on iopl
> there too,
>
> Changelog since v1:
> - change log message level from DEBUG to ERR,
> - add device name in log message,
>
> ---
> drivers/bus/pci/bsd/pci.c | 5 +++++
> drivers/bus/pci/linux/pci.c | 6 ++++++
> drivers/bus/pci/linux/pci_uio.c | 6 ++++++
> 3 files changed, 17 insertions(+)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-10-24 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 11:56 [dpdk-dev] [PATCH 0/2] Using virtio ethdev ports as non-root David Marchand
2019-10-17 11:56 ` [dpdk-dev] [PATCH 1/2] bus/pci: check IO permissions for UIO only David Marchand
2019-10-17 11:56 ` [dpdk-dev] [PATCH 2/2] net/virtio: do not require IO permissions David Marchand
2019-10-18 8:16 ` Tiwei Bie
2019-10-18 8:33 ` David Marchand
2019-10-18 10:05 ` Tiwei Bie
2019-10-20 12:29 ` [dpdk-dev] [PATCH v2 0/2] Using virtio ethdev ports as non-root David Marchand
2019-10-20 12:29 ` [dpdk-dev] [PATCH v2 1/2] bus/pci: check IO permissions for UIO only David Marchand
2019-10-20 12:29 ` [dpdk-dev] [PATCH v2 2/2] net/virtio: do not require IO permissions David Marchand
2019-10-21 13:10 ` [dpdk-dev] [PATCH v2 0/2] Using virtio ethdev ports as non-root Maxime Coquelin
2019-10-22 8:21 ` [dpdk-dev] [PATCH v3 " David Marchand
2019-10-22 8:21 ` [dpdk-dev] [PATCH v3 1/2] bus/pci: check IO permissions for UIO only David Marchand
2019-10-24 9:55 ` Maxime Coquelin [this message]
2019-10-22 8:21 ` [dpdk-dev] [PATCH v3 2/2] net/virtio: do not require IO permissions David Marchand
2019-10-23 4:56 ` Tiwei Bie
2019-10-25 10:11 ` [dpdk-dev] [PATCH v3 0/2] Using virtio ethdev ports as non-root David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521000af-998e-cffd-4a0a-8db4eb9b3ba0@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).