From: Thomas Monjalon <thomas@monjalon.net>
To: "Chen, Junjie J" <junjie.j.chen@intel.com>
Cc: dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function
Date: Wed, 18 Apr 2018 09:25:56 +0200 [thread overview]
Message-ID: <5237986.PrAvHOT1FH@xps> (raw)
In-Reply-To: <AA85A5A5E706C44BACB0BEFD5AC08BF6313EADBC@SHSMSX101.ccr.corp.intel.com>
18/04/2018 04:43, Chen, Junjie J:
> Thanks to point this out. I agree for the title change.
>
> Do you want me to send v2 patch? Or you can handle it when committing?
>
> > > > Sometimes gcc does not inline the function despite keyword *inline*,
> > > > we obeserve rte_movX is not inline when doing performance profiling,
> > > > so use *always_inline* keyword to force gcc to inline the function.
> > > >
> > > > Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com>
> > > > ---
> > > > .../common/include/arch/x86/rte_memcpy.h | 22
> > +++++++++++-----------
> > > > 1 file changed, 11 insertions(+), 11 deletions(-)
> > >
> > > The title should start with "eal/x86:"
> > > Something like that:
> > > eal/x86: force inlining of memcpy sub-functions
> > >
> > > Bruce, Konstantin, any review of the content/optimization?
> > >
> > No objection here.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-04-18 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 5:16 Junjie Chen
2018-04-17 13:22 ` Thomas Monjalon
2018-04-17 14:57 ` Bruce Richardson
2018-04-18 2:43 ` Chen, Junjie J
2018-04-18 7:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5237986.PrAvHOT1FH@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).