From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Neil Horman <nhroman@tuxdriver.com>,
Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] stats: remove useless memset's
Date: Tue, 27 Jan 2015 13:06:20 +0100 [thread overview]
Message-ID: <5262681.X6Q2U5C1BV@xps13> (raw)
In-Reply-To: <CALwxeUvgN+a1Lm=mBbKAdScVBMY3s5yZ3eg119L-NhXkf1MJnw@mail.gmail.com>
2015-01-21 14:08, David Marchand:
> Hello Stephen,
>
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > The rte_eth_stats_get is the only API that should call the device
> > statistics function directly, and it already does a memset of the
> > resulting structure. Therefore doing memset() in the driver is
> > redundant and should be removed.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 --
> > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 4 ----
> > lib/librte_pmd_enic/enic_main.c | 1 -
> > lib/librte_pmd_i40e/i40e_ethdev_vf.c | 1 -
> > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 -
> > lib/librte_pmd_ring/rte_eth_ring.c | 1 -
> > 6 files changed, 10 deletions(-)
> >
>
> I think you missed some :
> - lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get()
> - lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get()
>
> With these fixed :
> Acked-By: David Marchand <david.marchand@6wind.com>
Applied with above fixes.
Thanks
--
Thomas
prev parent reply other threads:[~2015-01-27 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 4:16 stephen
2015-01-21 12:43 ` Neil Horman
2015-01-21 13:08 ` David Marchand
2015-01-27 12:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5262681.X6Q2U5C1BV@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nhroman@tuxdriver.com \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).