From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] fix performance/cache resource issues with 128-byte cache line targets
Date: Mon, 07 Dec 2015 15:35:58 +0100 [thread overview]
Message-ID: <5319870.TBdLd4mWKW@xps13> (raw)
In-Reply-To: <20151207143300.GA20063@localhost.localdomain>
2015-12-07 20:03, Jerin Jacob:
> On Mon, Dec 07, 2015 at 03:40:13AM -0800, Thomas Monjalon wrote:
> > 2015-12-07 12:56, Jerin Jacob:
> > > On Sun, Dec 06, 2015 at 05:30:50PM +0100, Thomas Monjalon wrote:
> > > > 2015-12-06 21:29, Jerin Jacob:
> > > > > This patchset fixes performance/cache resource issues with 128-byte cache line targets
> > > > > found in mbuf and bitmap DPDK libraries
> > > > >
> > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on
> > > > > 128-bytes cache line size target.
> > > >
> > > > When introducing IBM Power8, we failed to clean the cache line size definition.
> > > > I promised to not forget this issue in this thread with Neil:
> > > > http://dpdk.org/ml/archives/dev/2014-December/009439.html
> > > >
> > > > It is defined in
> > > > config/defconfig_*
> > > > mk/machine/*/rte.vars.mk
> > > > mk/arch/*/rte.vars.mk
> > > > rte_memory.h
> > > > rte_kni_common.h
> > > >
> > > > It should be defined only in the config files.
> > > > When we will introduce a configure script, we should be able to detect it.
> > > >
> > > > Please Jerin, as ThunderX maintainer, may you help to fix this old mess?
> > >
> > > Yes Thomas, I will takeup this issue when we will have configure script.
> >
> > I thought we could start setting the value in only one place.
> > The detection in configure script would be another step.
>
> OK Thomas, I have sent the cleanup patch. Please review it.
You are too fast :)
I will review it but it will be deferred to 2.3.
next prev parent reply other threads:[~2015-12-07 14:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 15:59 Jerin Jacob
2015-12-06 15:59 ` [dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue " Jerin Jacob
2015-12-07 15:21 ` Ananyev, Konstantin
2015-12-08 12:45 ` Jerin Jacob
2015-12-08 16:07 ` Ananyev, Konstantin
2015-12-08 17:49 ` Jerin Jacob
2015-12-09 13:44 ` Ananyev, Konstantin
2015-12-09 14:49 ` Jerin Jacob
2015-12-06 15:59 ` [dpdk-dev] [PATCH 2/2] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-06 16:30 ` [dpdk-dev] [PATCH 0/2] fix performance/cache resource issues with 128-byte " Thomas Monjalon
2015-12-07 7:26 ` Jerin Jacob
2015-12-07 11:40 ` Thomas Monjalon
2015-12-07 14:33 ` Jerin Jacob
2015-12-07 14:35 ` Thomas Monjalon [this message]
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 0/4] " Jerin Jacob
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 1/4] eal: Introduce new cache macro definitions Jerin Jacob
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2015-12-11 12:55 ` Ananyev, Konstantin
2015-12-11 13:07 ` Thomas Monjalon
2015-12-11 13:56 ` Jerin Jacob
2015-12-11 14:42 ` Ananyev, Konstantin
2015-12-14 4:32 ` [dpdk-dev] [PATCH v3 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2015-12-14 4:32 ` [dpdk-dev] [PATCH v3 1/4] eal: Introduce new cache macro definitions Jerin Jacob
2016-01-04 13:15 ` Olivier MATZ
2016-01-06 15:10 ` Jerin Jacob
2015-12-14 4:32 ` [dpdk-dev] [PATCH v3 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2015-12-14 4:32 ` [dpdk-dev] [PATCH v3 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-14 4:32 ` [dpdk-dev] [PATCH v3 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2016-01-29 7:45 ` [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2016-01-29 7:45 ` [dpdk-dev] [PATCH v4 1/4] eal: Introduce new cache line macro definitions Jerin Jacob
2016-01-29 7:45 ` [dpdk-dev] [PATCH v4 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2016-01-29 7:45 ` [dpdk-dev] [PATCH v4 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2016-01-29 7:45 ` [dpdk-dev] [PATCH v4 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2016-02-08 9:31 ` [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2016-02-08 10:24 ` Jan Viktorin
2016-02-08 10:52 ` Jerin Jacob
2016-02-08 12:56 ` Jan Viktorin
2016-02-11 11:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319870.TBdLd4mWKW@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).