From: "Qiu, Michael" <michael.qiu@intel.com>
To: "He, Shaopeng" <shaopeng.he@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] fm10k: add MAC filter
Date: Tue, 9 Jun 2015 15:59:31 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286046959F8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1433213937-21690-3-git-send-email-shaopeng.he@intel.com>
On 2015/6/2 10:59, He, Shaopeng wrote:
> MAC filter function was newly added, each PF and VF can have up to 64 MAC
> addresses. VF filter needs support from PF host, which is not available now.
>
> Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> ---
> drivers/net/fm10k/fm10k.h | 3 +-
> drivers/net/fm10k/fm10k_ethdev.c | 90 ++++++++++++++++++++++++++++++++++++----
> 2 files changed, 85 insertions(+), 8 deletions(-)
...
> ;
> +
> + fm10k_mbx_lock(hw);
> + i = 0;
> + for (j = 0; j < FM10K_VFTA_SIZE; j++) {
> + if (macvlan->vfta[j]) {
> + for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
> + if (macvlan->vfta[j] & (1 << k)) {
> + if (i + 1 > macvlan->vlan_num) {
> + PMD_INIT_LOG(ERR, "vlan number "
> + "not match");
> + fm10k_mbx_unlock(hw);
> + return;
> + }
> + fm10k_update_uc_addr(hw,
> + hw->mac.dglort_map, mac,
Here before 'mac', does it has a incident? if no, please ignore, maybe
my mail client's issue.
Thanks,
Michael
> + j * FM10K_UINT32_BIT_SIZE + k,
> + add, 0);
> + i++;
> + }
> + }
> + }
> + }
> + fm10k_mbx_unlock(hw);
> +
> + if (add)
> + macvlan->mac_num++;
> + else
> + macvlan->mac_num--;
> +}
> +
> +/* Add a MAC address, and update filters */
> +static void
> +fm10k_macaddr_add(struct rte_eth_dev *dev,
> + struct ether_addr *mac_addr,
> + __rte_unused uint32_t index,
> + __rte_unused uint32_t pool)
> +{
> + fm10k_MAC_filter_set(dev, mac_addr->addr_bytes, TRUE);
> +}
> +
> +/* Remove a MAC address, and update filters */
> +static void
> +fm10k_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
> +{
> + struct rte_eth_dev_data *data = dev->data;
> +
> + if (index < FM10K_MAX_MACADDR_NUM)
> + fm10k_MAC_filter_set(dev, data->mac_addrs[index].addr_bytes,
> + FALSE);
> +}
> +
> static inline int
> check_nb_desc(uint16_t min, uint16_t max, uint16_t mult, uint16_t request)
> {
> @@ -1728,6 +1801,8 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {
> .link_update = fm10k_link_update,
> .dev_infos_get = fm10k_dev_infos_get,
> .vlan_filter_set = fm10k_vlan_filter_set,
> + .mac_addr_add = fm10k_macaddr_add,
> + .mac_addr_remove = fm10k_macaddr_remove,
> .rx_queue_start = fm10k_dev_rx_queue_start,
> .rx_queue_stop = fm10k_dev_rx_queue_stop,
> .tx_queue_start = fm10k_dev_tx_queue_start,
> @@ -1809,7 +1884,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
> }
>
> /* Initialize MAC address(es) */
> - dev->data->mac_addrs = rte_zmalloc("fm10k", ETHER_ADDR_LEN, 0);
> + dev->data->mac_addrs = rte_zmalloc("fm10k",
> + ETHER_ADDR_LEN * FM10K_MAX_MACADDR_NUM, 0);
> if (dev->data->mac_addrs == NULL) {
> PMD_INIT_LOG(ERR, "Cannot allocate memory for MAC addresses");
> return -ENOMEM;
next prev parent reply other threads:[~2015-06-09 16:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 2:58 [dpdk-dev] [PATCH 0/3] fm10k: update MAC/VLAN filter and VLAN offload features Shaopeng He
2015-06-02 2:58 ` [dpdk-dev] [PATCH 1/3] fm10k: update VLAN filter Shaopeng He
2015-06-09 2:54 ` Chen, Jing D
2015-06-09 7:18 ` He, Shaopeng
2015-06-09 15:51 ` Qiu, Michael
2015-06-10 5:52 ` He, Shaopeng
2015-06-02 2:58 ` [dpdk-dev] [PATCH 2/3] fm10k: add MAC filter Shaopeng He
2015-06-09 3:25 ` Chen, Jing D
2015-06-09 8:31 ` He, Shaopeng
2015-06-09 15:59 ` Qiu, Michael [this message]
2015-06-10 1:03 ` He, Shaopeng
2015-06-02 2:58 ` [dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features Shaopeng He
2015-06-09 3:27 ` Chen, Jing D
2015-06-09 8:55 ` He, Shaopeng
2015-06-09 15:40 ` Qiu, Michael
2015-06-10 6:03 ` He, Shaopeng
2015-06-15 1:23 ` [dpdk-dev] [PATCH v2 0/3] fm10k: update MAC/VLAN filter and " Shaopeng He
2015-06-15 1:23 ` [dpdk-dev] [PATCH v2 1/3] fm10k: update VLAN filter Shaopeng He
2015-06-15 1:23 ` [dpdk-dev] [PATCH v2 2/3] fm10k: add MAC filter Shaopeng He
2015-06-16 12:38 ` Qiu, Michael
2015-06-15 1:23 ` [dpdk-dev] [PATCH v2 3/3] fm10k: update VLAN offload features Shaopeng He
2015-06-18 7:21 ` [dpdk-dev] [PATCH v3 0/3] fm10k: update MAC/VLAN filter and " Shaopeng He
2015-06-18 7:21 ` [dpdk-dev] [PATCH v3 1/3] fm10k: update VLAN filter Shaopeng He
2015-06-18 7:21 ` [dpdk-dev] [PATCH v3 2/3] fm10k: add MAC filter Shaopeng He
2015-06-18 7:21 ` [dpdk-dev] [PATCH v3 3/3] fm10k: update VLAN offload features Shaopeng He
2015-06-18 8:23 ` [dpdk-dev] [PATCH v3 0/3] fm10k: update MAC/VLAN filter and " Chen, Jing D
2015-06-22 14:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286046959F8@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
--cc=shaopeng.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).