From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "He, Shaopeng" <shaopeng.he@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/6] fm10k: Fix jumbo frame issue
Date: Fri, 12 Jun 2015 01:15:41 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E602860469B19E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1432887044-24777-3-git-send-email-jing.d.chen@intel.com>
Tested-by: Michael Qiu <michael.qiu@intel.com>
- OS: Fedora20 3.11.10-301
- GCC: gcc version 4.8.3 2014911
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Ethernet controller: Intel Corporation Device 15a4 (rev 01)
- Default x86_64-native-linuxapp-gcc configuration
- Total 5 cases, 5 passed, 0 failed
- Case: Normal frames with no jumbo frame support
- Case: Jumbo frames with no jumbo frame support
- Case: Normal frames with jumbo frame support
- Case: Jumbo frames with jumbo frame support
- Case: Frames bigger than jumbo frames, wwith jumbo frame support
On 5/29/2015 4:11 PM, Chen, Jing D wrote:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> fm10k can't receive frame greater than 1536 and Scatter RX
> function can't work correctly. The root cause is
> SRRCTL.FM10K_SRRCTL_BUFFER_CHAINING_EN bit is not enabled.
>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
> index a5e09a0..19e718b 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -439,9 +439,14 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
>
> /* It adds dual VLAN length for supporting dual VLAN */
> if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
> - 2 * FM10K_VLAN_TAG_SIZE) > buf_size){
> + 2 * FM10K_VLAN_TAG_SIZE) > buf_size ||
> + dev->data->dev_conf.rxmode.enable_scatter) {
> + uint32_t reg;
> dev->data->scattered_rx = 1;
> dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
> + reg = FM10K_READ_REG(hw, FM10K_SRRCTL(i));
> + reg |= FM10K_SRRCTL_BUFFER_CHAINING_EN;
> + FM10K_WRITE_REG(hw, FM10K_SRRCTL(i), reg);
> }
>
> /* Enable drop on empty, it's RO for VF */
> @@ -452,11 +457,6 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
> FM10K_WRITE_FLUSH(hw);
> }
>
> - if (dev->data->dev_conf.rxmode.enable_scatter) {
> - dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
> - dev->data->scattered_rx = 1;
> - }
> -
> /* Configure RSS if applicable */
> fm10k_dev_mq_rx_configure(dev);
> return 0;
next prev parent reply other threads:[~2015-06-12 1:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 8:10 [dpdk-dev] [PATCH 0/6] fm10k: A series of bug fixes Chen Jing D(Mark)
2015-05-29 8:10 ` [dpdk-dev] [PATCH 1/6] fm10k: Fix improper RX buffer size assignment Chen Jing D(Mark)
2015-06-16 11:55 ` Qiu, Michael
2015-05-29 8:10 ` [dpdk-dev] [PATCH 2/6] fm10k: Fix jumbo frame issue Chen Jing D(Mark)
2015-06-12 1:15 ` Qiu, Michael [this message]
2015-05-29 8:10 ` [dpdk-dev] [PATCH 3/6] fm10k: Fix data integrity issue with multi-segment frame Chen Jing D(Mark)
2015-06-16 12:07 ` Qiu, Michael
2015-05-29 8:10 ` [dpdk-dev] [PATCH 4/6] fm10k: Fix issue that MAC addr can't be set to silicon Chen Jing D(Mark)
2015-06-09 16:23 ` Qiu, Michael
2015-06-10 5:34 ` Chen, Jing D
2015-06-12 2:03 ` Qiu, Michael
2015-05-29 8:10 ` [dpdk-dev] [PATCH 5/6] fm10k: Do sanity check on mac address Chen Jing D(Mark)
2015-06-16 12:08 ` Qiu, Michael
2015-05-29 8:10 ` [dpdk-dev] [PATCH 6/6] fm10k: Add default mac/vlan filter to SM Chen Jing D(Mark)
2015-06-08 2:39 ` [dpdk-dev] [PATCH 0/6] fm10k: A series of bug fixes He, Shaopeng
2015-06-09 15:21 ` Qiu, Michael
2015-06-22 13:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E602860469B19E@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=shaopeng.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).