DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Qiu, Michael" <michael.qiu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check
Date: Tue, 27 Jan 2015 12:00:59 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CBAD55@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <3276396.omH03JUPtz@xps13>

On 1/27/2015 6:02 PM, Thomas Monjalon wrote:
> Hi Michael,
>
> I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
> reviewing this patch. However I have few comments.

Thanks Thomas,

I will send v2 with your comments.

But who maintains ixgbe? I would like add him(or she) to the cc list.

> 2015-01-15 22:45, Michael Qiu:
>> -	ixgbe_dev_rxtx_start(dev);
>> +	err = ixgbe_dev_rxtx_start(dev);
>> +	if (err < 0) {
>> +		PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");
> \n is not needed in PMD_INIT_LOG.
>
> Is this useful to print a log here, given that there already has
> some logs in ixgbe_dev_rxtx_start?

You are right, what I'm opinion is to show more details about the error,
but seems duplicated.

I will remove it.

Thanks,
Michael
>
>> +				PMD_INIT_LOG(ERR, "Start tx queue failed\n");
> [...]
>> +				PMD_INIT_LOG(ERR, "Start rx queue failed\n");
> Please remove \n.
>
> Except these minor comments, it looks good.
> Thanks

next prev parent reply	other threads:[~2015-01-27 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 14:45 Michael Qiu
2015-01-19 15:50 ` Qiu, Michael
2015-01-27 10:00 ` Thomas Monjalon
2015-01-27 12:00   ` Qiu, Michael [this message]
2015-01-27 14:14     ` Thomas Monjalon
2015-01-27 12:16 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-01-27 14:12   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E60286CBAD55@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).