From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
Date: Wed, 18 Mar 2015 04:48:35 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286D14935@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213F5E13@irsmsx105.ger.corp.intel.com>
On 3/13/2015 5:45 PM, Ananyev, Konstantin wrote:
> Hi Michael,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
>> Sent: Friday, March 13, 2015 7:03 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
>>
>> rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h"
>>
>> For icc and old gcc, this header is not included.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>> ---
>> lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
>> index ac72069..bd10d36 100644
>> --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
>> +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
>> @@ -43,7 +43,27 @@
>> #include <stdio.h>
>> #include <stdint.h>
>> #include <string.h>
>> +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4))
>> +
>> +#ifdef __SSE__
>> +#include <xmmintrin.h>
>> +#endif
>> +
>> +#ifdef __SSE2__
>> +#include <emmintrin.h>
>> +#endif
>> +
>> +#if defined(__SSE4_2__) || defined(__SSE4_1__)
>> +#include <smmintrin.h>
>> +#endif
>> +
>> +#if defined(__AVX__)
>> +#include <immintrin.h>
>> +#endif
>> +
>> +#else
>> #include <x86intrin.h>
>> +#endif
>>
>> #ifdef __cplusplus
>> extern "C" {
>> --
>> 1.9.3
> Wonder why to spread this thing over?
> Why not just #include <rte_common_vec.h>?
Yes, I will send other patch to fix this,
Thanks,
Michael
> Konstantin
>
>
>
>
next prev parent reply other threads:[~2015-03-18 4:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 7:02 Michael Qiu
2015-03-13 7:08 ` Wang, Zhihong
2015-03-13 9:44 ` Ananyev, Konstantin
2015-03-16 16:05 ` Thomas Monjalon
2015-03-16 17:39 ` Ananyev, Konstantin
2015-03-17 8:46 ` Thomas Monjalon
2015-03-18 4:48 ` Qiu, Michael [this message]
2015-03-13 14:25 ` Mcnamara, John
2015-03-16 4:44 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286D14935@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).