DPDK patches and discussions
 help / color / mirror / Atom feed

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gregory Etelson <getelson@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: <matan@nvidia.com>, <rasland@nvidia.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush
Date: Wed, 3 Nov 2021 19:12:47 +0000	[thread overview]
Message-ID: <53762631-743c-0d11-0693-47e4ec6b67e4@intel.com> (raw)
In-Reply-To: <20211026152000.11665-1-getelson@nvidia.com>

On 10/26/2021 4:20 PM, Gregory Etelson wrote:
> Testpmd provides 2 sets of flex item create and destroy functions
> One for hosts with JSON library. These functions parse
> flex item configuration stored in JSON file and create or destroy
> flex item object. The second functions set is for hosts without JSON
> library for compilation compatibility.
> 
> On hosts without JSON library, current implementation issues
> "no JSON library" notification on port close.
> The notification was triggered by port destructors that include
> flex items flush routine.
> 
> The patch introduces single implementation for testpmd
> flex item destroy.
> 
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
> Signed-off-by: Gregory Etelson<getelson@nvidia.com>
> ---
>   app/test-pmd/cmd_flex_item.c | 72 ++++++++++++++++++------------------


Hi Gregory, Ori,

I just recognized that 'cmd_flex_item.c' doesn't have an explicit maintainer,
which makes it fallback to Xialyoun, but I don't think that is related to
existing coverage.

Since the file is related to rte_flow and only user of it (also author of it)
is nvidia, can one of you take the maintainership of the file?

It is easier to add it to 'Flow API' block in MAINTAINERS file,
that Ori already is the maintainer, if that suits.

And perhaps, if you guys are OK, Gregory can be added to 'Flow API' too,
it is good to have multiple maintainers.

Thanks,
ferruh

next prev parent reply	other threads:[~2021-11-03 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 15:20 Gregory Etelson
2021-11-03 19:12 ` Ferruh Yigit [this message]
2021-11-05 15:56 ` Ferruh Yigit
2021-11-05 17:03   ` Slava Ovsiienko
2021-11-05 18:56     ` Ferruh Yigit
2021-11-05 21:21     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53762631-743c-0d11-0693-47e4ec6b67e4@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=getelson@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).