From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Dai <wei.dai@intel.com>,
jingjing.wu@intel.com, beilei.xing@intel.com,
helin.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time
Date: Mon, 8 Jan 2018 13:23:01 +0000 [thread overview]
Message-ID: <53f0e811-d0e1-7b23-1a81-f8d9639c6f09@intel.com> (raw)
In-Reply-To: <1514301894-58374-1-git-send-email-wei.dai@intel.com>
On 12/26/2017 3:24 PM, Wei Dai wrote:
> Without this patch, the number of queues per i40e VF is defined as 4
> by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base.
> It is fixed value determined in building time and can't be changed
> during run time.
> With this patch, the number of queues per i40e VF can be determinated
> during run time. For example, if the PCI address of an i40e PF is
> aaaa:bb.cc, with the EAL parameter -w aaaa:bb.cc,queue-num-per-vf=8 ,
> the number of queues per VF created from this PF is 8.
> If there is no "queue-num-per-vf" setting in EAL parameters, it is 4
> by default as before. And if the value after the "queue-num-per-vf"
> is invalid, it is set as 4 forcibly. The valid values include 1, 2, 4,
> 8, 16 .
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> v9:
> v9 = v8+v7, is a complete version for maintainer's convenience.
> v8:
> As v7 patch has been accepted into dpdk-next-net-intel, this patch
> is based on v7 patch.
> add description in i40e document
> fix the last member of valid_keys[] for rte_kvargs_parse( )
> add RTE_PMD_REGISTER_PARAM_STRING for this feature
> v7:
> use the macro instead of natural number
> correct git log message as the EAL parameter is only valid for PF
> v6:
> fix a small bug when detecting end character of strtoul
> v5:
> fix git log message and WARNING of coding stype
> v4:
> use rte_kvargs instead of pervious parsing function;
> use malloc/free instead of rte_zmalloc/rte_free.
> v3:
> fix WARNING of coding style issues from checkpatch@dpdk.org
> v2:
> fix WARNING of coding style issues from checkpatch@dpdk.org
> ---
> config/common_base | 1 -
> doc/guides/nics/i40e.rst | 12 ++++---
> drivers/net/i40e/i40e_ethdev.c | 75 +++++++++++++++++++++++++++++++++++++++---
> 3 files changed, 78 insertions(+), 10 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index e74febe..4e20389 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -208,7 +208,6 @@ CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
> CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
> CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
> -CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4
> CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=4
> # interval up to 8160 us, aligned to 2 (or default value)
> CONFIG_RTE_LIBRTE_I40E_ITR_INTERVAL=-1
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
> index cd46874..abb20da 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -115,10 +115,6 @@ Please note that enabling debugging options may affect system performance.
>
> Number of queues reserved for PF.
>
> -- ``CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF`` (default ``4``)
> -
> - Number of queues reserved for each SR-IOV VF.
> -
> - ``CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM`` (default ``4``)
>
Hi Wei,
What do you think creating a section for "Runtime config options" in same level
for "Config File Options" and explain new "queue-num-per-vf" option there?
Thanks,
ferruh
next prev parent reply other threads:[~2018-01-08 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 7:43 [dpdk-dev] [PATCH v2] " Wei Dai
2017-11-19 14:08 ` [dpdk-dev] [PATCH v3] " Wei Dai
2017-11-20 11:32 ` Ananyev, Konstantin
2017-11-22 2:46 ` Dai, Wei
2017-11-22 14:10 ` [dpdk-dev] [PATCH v4] " Wei Dai
2017-11-24 6:12 ` [dpdk-dev] [PATCH v5] " Wei Dai
2017-11-27 8:08 ` [dpdk-dev] [PATCH v6] " Wei Dai
2017-12-03 11:19 ` Ananyev, Konstantin
2017-12-08 1:53 ` [dpdk-dev] [PATCH v7] " Wei Dai
2017-12-11 2:33 ` Peng, Yuan
2017-12-20 5:59 ` Zhang, Helin
2017-12-25 11:45 ` [dpdk-dev] [PATCH v8] " Wei Dai
2017-12-26 15:24 ` [dpdk-dev] [PATCH v9] " Wei Dai
2018-01-08 6:00 ` Zhang, Helin
2018-01-09 9:09 ` Dai, Wei
2018-01-08 13:23 ` Ferruh Yigit [this message]
2018-01-09 8:56 ` [dpdk-dev] [PATCH v10] " Wei Dai
2018-01-09 14:36 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f0e811-d0e1-7b23-1a81-f8d9639c6f09@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).