From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag
Date: Tue, 19 Dec 2017 10:59:26 +0530 [thread overview]
Message-ID: <53f0f426-2d0b-1cbb-2161-0d03ba0b76f9@nxp.com> (raw)
In-Reply-To: <4147827.fBL4TnQB7r@xps>
On 12/18/2017 10:00 PM, Thomas Monjalon wrote:
> 18/12/2017 16:52, Bruce Richardson:
>> On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote:
>>> --- a/GNUmakefile
>>> +++ b/GNUmakefile
>>> @@ -1,33 +1,6 @@
>>> -# BSD LICENSE
>>> +# SPDX-License-Identifier: BSD-3-Clause
>>> #
>>> # Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
>>
>> Actually, minor comment, can we remove the blank line between the SPDX
>> identifier and the copyright? Given that in the majority of cases, we
>> will only have one line each, having a space between them is a) probably
>> unnecessary, and b) looks weird IMHO.
>>
>> I'm currently working on a patchset to update the meson.build files, and
>> I think having:
>>
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright(c) 2017 Intel Corporation
>>
>> looks better as a header than two one-line paragraphs.
>
> +1, I agree with Bruce
>
I will fix it.
However, I will suggest to not enforced it as a policy. Let the
copyright owners decide, how they want to place the copyright.
next prev parent reply other threads:[~2017-12-19 5:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 7:46 [dpdk-dev] [PATCH 1/2] Introducing SPDX License Identifiers Hemant Agrawal
2017-11-27 7:46 ` [dpdk-dev] [PATCH 2/2] Change root makefile license to SPDX tag Hemant Agrawal
2017-11-27 12:01 ` Bruce Richardson
2017-12-01 8:41 ` Hemant Agrawal
2017-11-28 16:59 ` [dpdk-dev] [PATCH 1/2] Introducing SPDX License Identifiers Stephen Hemminger
2017-12-01 8:38 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2017-12-01 8:38 ` [dpdk-dev] [PATCH v2 2/2] Change root makefile license to SPDX tag Hemant Agrawal
2017-12-07 23:46 ` [dpdk-dev] [PATCH v2 1/2] Introducing SPDX License Identifiers Ferruh Yigit
2017-12-08 4:57 ` Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 1/4] " Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-08 18:07 ` Stephen Hemminger
2017-12-08 7:41 ` [dpdk-dev] [PATCH v3 4/4] change NXP dpaa " Hemant Agrawal
2017-12-13 10:46 ` [dpdk-dev] [PATCH v3 1/4] Introducing SPDX License Identifiers Thomas Monjalon
2017-12-13 11:38 ` Bruce Richardson
2017-12-13 15:38 ` Wiles, Keith
2017-12-15 10:52 ` Hemant Agrawal
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 " Hemant Agrawal
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-18 14:32 ` Bruce Richardson
2017-12-18 15:52 ` Bruce Richardson
2017-12-18 16:30 ` Thomas Monjalon
2017-12-19 5:29 ` Hemant Agrawal [this message]
2017-12-19 10:01 ` Bruce Richardson
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-18 12:39 ` [dpdk-dev] [PATCH v4 4/4] change NXP dpaa " Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 1/4] Introducing SPDX License Identifiers Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 2/4] change root makefile license to SPDX tag Hemant Agrawal
2017-12-19 10:23 ` Bruce Richardson
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 3/4] change NXP dpaa2 code License text to SPDX tags Hemant Agrawal
2017-12-19 10:14 ` [dpdk-dev] [PATCH v5 4/4] change NXP dpaa " Hemant Agrawal
2018-01-04 18:32 ` [dpdk-dev] [PATCH v5 1/4] Introducing SPDX License Identifiers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f0f426-2d0b-1cbb-2161-0d03ba0b76f9@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).