From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: remove duplicate checks for cflags
Date: Thu, 26 Jul 2018 10:10:42 +0200 [thread overview]
Message-ID: <5416350.4EgPhb2RIe@xps> (raw)
In-Reply-To: <20180719142206.1478-1-bruce.richardson@intel.com>
19/07/2018 16:22, Bruce Richardson:
> There is no need to check for each library, driver and example whether
> certain cflags are supported. Instead of checking inside the loop, do
> so outside and reuse the value.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
The build log looks cleaner.
Applied, thanks
prev parent reply other threads:[~2018-07-26 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 14:22 Bruce Richardson
2018-07-26 8:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416350.4EgPhb2RIe@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).