From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
jianbo.liu@arm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] net/mvpp2: implement dynamic logging
Date: Thu, 31 May 2018 15:02:20 +0100 [thread overview]
Message-ID: <5425a135-b175-63bc-5a38-f84f911f153c@intel.com> (raw)
In-Reply-To: <20180426104438.GA13926@sh>
On 4/26/2018 11:44 AM, Tomasz Duszynski wrote:
> Hello Stephen,
>
> A few nits on this inline.
Hi Tomasz,
This was an RFC targeting your driver.
Can you re-spin the patch with your suggested updates?
>
> On Wed, Apr 25, 2018 at 09:44:54AM -0700, Stephen Hemminger wrote:
>> All DPDK drivers should use dynamic log types, not the default PMD
>> value.
>>
>> This is an RFC not a patch since I don't have libraries are
>> hardware to validate it.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
prev parent reply other threads:[~2018-05-31 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 16:44 Stephen Hemminger
2018-04-26 10:44 ` Tomasz Duszynski
2018-05-31 14:02 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5425a135-b175-63bc-5a38-f84f911f153c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=jck@semihalf.com \
--cc=jianbo.liu@arm.com \
--cc=nsamsono@marvell.com \
--cc=stephen@networkplumber.org \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).