From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations
Date: Wed, 15 Jun 2016 11:27:07 +0200 [thread overview]
Message-ID: <54322711.BUndy8Ap0U@xps13> (raw)
In-Reply-To: <1465982245-1162-2-git-send-email-remy.horton@intel.com>
2016-06-15 10:17, Remy Horton:
> +enum rte_keepalive_state {
> + RTE_UNUSED = 0,
> + RTE_ALIVE = 1,
> + RTE_MISSING = 4,
> + RTE_DEAD = 2,
> + RTE_GONE = 3,
> + RTE_DOZING = 5,
> + RTE_SLEEP = 6
> +};
I'm concerned about the namespace here.
RTE_UNUSED and others have a chance to not be unique enough.
Is it possible to have a longer prefix like RTE_KA_ or RTE_STATE_
or RTE_KA_STATE_?
next prev parent reply other threads:[~2016-06-15 9:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 5:41 [dpdk-dev] [PATCH v1 0/3] Keep-alive enhancements Remy Horton
2016-04-29 5:41 ` [dpdk-dev] [PATCH v1 1/3] eal: add new keepalive state & callback hook Remy Horton
2016-04-29 5:41 ` [dpdk-dev] [PATCH v1 2/3] examples/l2fwd-keepalive: add IPC liveness reporting Remy Horton
2016-04-29 5:41 ` [dpdk-dev] [PATCH v1 3/3] doc: add keepalive enhancement documentation Remy Horton
2016-05-17 7:30 ` [dpdk-dev] FW: [PATCH v1 0/3] Keep-alive enhancements Liu, Shucong
2016-05-18 9:30 ` [dpdk-dev] [PATCH v2 " Remy Horton
2016-05-18 9:30 ` [dpdk-dev] [PATCH v2 1/3] eal: add new keepalive states & callback hooks Remy Horton
2016-06-08 9:53 ` Thomas Monjalon
2016-05-18 9:30 ` [dpdk-dev] [PATCH v2 2/3] examples/l2fwd-keepalive: add IPC liveness reporting Remy Horton
2016-05-18 9:30 ` [dpdk-dev] [PATCH v2 3/3] doc: add keepalive enhancement documentation Remy Horton
2016-06-08 9:52 ` Thomas Monjalon
2016-06-14 10:03 ` Remy Horton
2016-06-02 13:57 ` [dpdk-dev] [PATCH v2 0/3] Keep-alive enhancements Tahhan, Maryam
2016-06-15 9:17 ` [dpdk-dev] [PATCH v3 " Remy Horton
2016-06-15 9:17 ` [dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations Remy Horton
2016-06-15 9:27 ` Thomas Monjalon [this message]
2016-06-15 9:32 ` Remy Horton
2016-06-15 9:17 ` [dpdk-dev] [PATCH v3 2/3] eal: add additional keepalive callbacks Remy Horton
2016-06-15 9:17 ` [dpdk-dev] [PATCH v3 3/3] examples/l2fwd-keepalive: add IPC liveness reporting Remy Horton
2016-06-15 15:25 ` [dpdk-dev] [PATCH v4 0/3] Keep-alive enhancements Remy Horton
2016-06-15 15:25 ` [dpdk-dev] [PATCH v4 1/3] eal: export keepalive state enumerations Remy Horton
2016-06-15 15:25 ` [dpdk-dev] [PATCH v4 2/3] eal: add additional keepalive callbacks Remy Horton
2016-06-15 15:25 ` [dpdk-dev] [PATCH v4 3/3] examples/l2fwd-keepalive: add IPC liveness reporting Remy Horton
2016-06-16 16:30 ` [dpdk-dev] [PATCH v4 0/3] Keep-alive enhancements Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54322711.BUndy8Ap0U@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).