DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yerden Zhumabekov <e_zhumabekov@sts.kz>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation
Date: Thu, 20 Nov 2014 09:04:43 +0600	[thread overview]
Message-ID: <546D5A4B.8030803@sts.kz> (raw)
In-Reply-To: <20141119150725.GB28013@localhost.localdomain>


19.11.2014 21:07, Neil Horman пишет:
> On Wed, Nov 19, 2014 at 05:35:51PM +0600, Yerden Zhumabekov wrote:
>> static inline uint32_t
>> crc32_sse42_u32(uint32_t data, uint32_t init_val)
>> {
>> /*··__asm__ volatile(
>> ············"crc32l %[data], %[init_val];"
>> ············: [init_val] "+r" (init_val)
>> ············: [data] "rm" (data));
>> ····return init_val;*/
>>
>> But wait, will __builtin_ia32_crc32si and __builtin_ia32_crc32di
>> functions do the trick? ICC has them?
> If builtins work on both icc and gcc, yes, that would be a solution as it
> creates non sse instructions when the target cpu doesn't support it.

Can anyone acknowledge?

>
>> What about prototyping functions and extracting their bodies to separate
>> module? Does it break anything?
>>
> That would be a variant on the asm inline idea, but yes, I think that would work
> too

No luck. Performance degrades up to 30-50 percent if extracting
functions to separate module.

-- 
Sincerely,

Yerden Zhumabekov
State Technical Service
Astana, KZ

  reply	other threads:[~2014-11-20  2:54 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  6:05 [dpdk-dev] [PATCH 0/2] rewritten rte_hash_crc() call Yerden Zhumabekov
2014-09-03  6:05 ` [dpdk-dev] [PATCH 1/2] hash: add new rte_hash_crc_8byte call Yerden Zhumabekov
2014-09-03  6:05 ` [dpdk-dev] [PATCH 2/2] hash: rte_hash_crc uses 8- and 4-byte CRC32 intrinsics Yerden Zhumabekov
2014-11-13 17:33 ` [dpdk-dev] [PATCH 0/2] rewritten rte_hash_crc() call Thomas Monjalon
2014-11-14  0:52   ` Neil Horman
2014-11-14  7:15     ` Yerden Zhumabekov
2014-11-14 11:33       ` Neil Horman
2014-11-14 11:57         ` Yerden Zhumabekov
2014-11-14 13:53           ` Neil Horman
2014-11-14 14:33             ` Thomas Monjalon
2014-11-14 16:43             ` Yerden Zhumabekov
2014-11-14 18:41               ` Neil Horman
2014-11-15 21:45                 ` Yerden Zhumabekov
2014-11-16 17:59 ` [dpdk-dev] [PATCH v2 0/4] rte_hash_crc reworked to be platform-independent Yerden Zhumabekov
2014-11-17 11:31   ` Neil Horman
2014-11-17 11:54     ` Yerden Zhumabekov
2014-11-25 17:05       ` Stephen Hemminger
2014-11-18  3:21   ` [dpdk-dev] [PATCH v3 0/5] " Yerden Zhumabekov
2014-11-18  3:21     ` [dpdk-dev] [PATCH v3 1/5] hash: add software CRC32 implementation Yerden Zhumabekov
2014-11-25 17:34       ` Stephen Hemminger
2014-11-18  3:21     ` [dpdk-dev] [PATCH v3 2/5] hash: add new rte_hash_crc_8byte call Yerden Zhumabekov
2014-11-18  3:21     ` [dpdk-dev] [PATCH v3 3/5] hash: add fallback to software CRC32 implementation Yerden Zhumabekov
2014-11-18  4:56       ` Yerden Zhumabekov
2014-11-18 13:33         ` Neil Horman
2014-11-18 13:37           ` Yerden Zhumabekov
2014-11-18 13:43           ` Thomas Monjalon
2014-11-18  3:21     ` [dpdk-dev] [PATCH v3 4/5] hash: rte_hash_crc() slices data into 8-byte pieces Yerden Zhumabekov
2014-11-18  3:25     ` [dpdk-dev] [PATCH v3 5/5] test: remove redundant compile checks Yerden Zhumabekov
2014-11-16 17:59 ` [dpdk-dev] [PATCH v2 1/4] hash: add software CRC32 implementation Yerden Zhumabekov
2014-11-16 17:59 ` [dpdk-dev] [PATCH v2 2/4] hash: add new rte_hash_crc_8byte call Yerden Zhumabekov
2014-11-16 17:59 ` [dpdk-dev] [PATCH v2 3/4] hash: add fallback to software CRC32 implementation Yerden Zhumabekov
2014-11-17 12:34   ` Ananyev, Konstantin
2014-11-17 12:41     ` Yerden Zhumabekov
2014-11-17 14:06     ` Neil Horman
2014-11-16 17:59 ` [dpdk-dev] [PATCH v2 4/4] hash: rte_hash_crc() slices data into 8-byte pieces Yerden Zhumabekov
2014-11-18 14:03 ` [dpdk-dev] [PATCH v4 0/5] rte_hash_crc reworked to be platform-independent Yerden Zhumabekov
2014-11-18 14:03   ` [dpdk-dev] [PATCH v4 1/5] hash: add software CRC32 implementation Yerden Zhumabekov
2014-11-18 14:03   ` [dpdk-dev] [PATCH v4 2/5] hash: add new rte_hash_crc_8byte call Yerden Zhumabekov
2014-11-18 14:03   ` [dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation Yerden Zhumabekov
2014-11-18 14:41     ` Neil Horman
2014-11-18 15:06       ` Yerden Zhumabekov
2014-11-18 16:00         ` Neil Horman
2014-11-18 16:04           ` Bruce Richardson
2014-11-18 16:08             ` Bruce Richardson
2014-11-18 16:38             ` Neil Horman
2014-11-18 17:13           ` Yerden Zhumabekov
2014-11-18 17:29             ` Wang, Shawn
2014-11-19  4:07               ` Yerden Zhumabekov
2014-11-18 17:46             ` Neil Horman
2014-11-18 17:52               ` Bruce Richardson
2014-11-18 21:36                 ` Neil Horman
2014-11-19  3:51                   ` Yerden Zhumabekov
2014-11-19 10:16                   ` Bruce Richardson
2014-11-19 11:34                     ` Neil Horman
2014-11-19 11:38                       ` Bruce Richardson
2014-11-19 11:50                         ` Ananyev, Konstantin
2014-11-19 11:59                           ` Yerden Zhumabekov
2014-11-19 15:05                           ` Neil Horman
2014-11-19 16:51                             ` Ananyev, Konstantin
2014-11-19 11:35                     ` Yerden Zhumabekov
2014-11-19 15:07                       ` Neil Horman
2014-11-20  3:04                         ` Yerden Zhumabekov [this message]
2014-11-18 17:58               ` Yerden Zhumabekov
2014-11-18 14:03   ` [dpdk-dev] [PATCH v4 4/5] hash: rte_hash_crc() slices data into 8-byte pieces Yerden Zhumabekov
2014-11-18 14:05   ` [dpdk-dev] [PATCH v4 5/5] test: remove redundant compile checks Yerden Zhumabekov
2014-11-20  5:15 ` [dpdk-dev] [PATCH v5 0/7] rte_hash_crc reworked to be platform-independent Yerden Zhumabekov
2014-11-20  5:16   ` [dpdk-dev] [PATCH v5 1/7] hash: add software CRC32 implementation Yerden Zhumabekov
2014-11-20  5:16   ` [dpdk-dev] [PATCH v5 2/7] hash: add assembly implementation of CRC32 intrinsics Yerden Zhumabekov
2014-11-20  5:16   ` [dpdk-dev] [PATCH v5 3/7] hash: replace built-in functions implementing SSE4.2 Yerden Zhumabekov
2014-11-20  5:16   ` [dpdk-dev] [PATCH v5 4/7] hash: add rte_hash_crc_8byte function Yerden Zhumabekov
2014-11-21 11:22     ` Neil Horman
2014-11-21 11:26       ` Yerden Zhumabekov
2014-11-20  5:17   ` [dpdk-dev] [PATCH v5 6/7] hash: rte_hash_crc() slices data into 8-byte pieces Yerden Zhumabekov
2014-11-20  5:17   ` [dpdk-dev] [PATCH v5 7/7] test: remove redundant compile checks Yerden Zhumabekov
2014-11-20  5:17   ` [dpdk-dev] [PATCH v5 5/7] hash: add fallback to software CRC32 implementation Yerden Zhumabekov
2014-11-27 21:04   ` [dpdk-dev] [PATCH v5 0/7] rte_hash_crc reworked to be platform-independent Thomas Monjalon
2014-11-28  3:28     ` Yerden Zhumabekov
2015-01-29  8:48 ` [dpdk-dev] [PATCH v6 " Yerden Zhumabekov
2015-01-29  8:48   ` [dpdk-dev] [PATCH v6 1/7] hash: add software CRC32 implementation Yerden Zhumabekov
2015-01-29  8:48   ` [dpdk-dev] [PATCH v6 2/7] hash: add assembly implementation of CRC32 intrinsics Yerden Zhumabekov
2015-02-02  5:15     ` Liang, Cunming
2015-02-02  5:34       ` Yerden Zhumabekov
2015-02-02  5:59         ` Liang, Cunming
2015-01-29  8:49   ` [dpdk-dev] [PATCH v6 3/7] hash: replace built-in functions implementing SSE4.2 Yerden Zhumabekov
2015-01-29  8:49   ` [dpdk-dev] [PATCH v6 4/7] hash: add rte_hash_crc_8byte function Yerden Zhumabekov
2015-01-29  8:50   ` [dpdk-dev] [PATCH v6 5/7] hash: add fallback to software CRC32 implementation Yerden Zhumabekov
2015-01-29  8:50   ` [dpdk-dev] [PATCH v6 6/7] hash: rte_hash_crc() slices data into 8-byte pieces Yerden Zhumabekov
2015-01-29  8:50   ` [dpdk-dev] [PATCH v6 7/7] test: remove redundant compile checks Yerden Zhumabekov
2015-02-01 14:13   ` [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent Neil Horman
2015-02-02  3:07     ` Yerden Zhumabekov
2015-02-02  3:31       ` Neil Horman
2015-02-02  5:18         ` [dpdk-dev] HA: " Жумабеков Ерден Мирзагулович
2015-02-02  5:39         ` [dpdk-dev] " Yerden Zhumabekov
2015-02-19 15:21           ` Bruce Richardson
2015-02-23 17:36             ` Thomas Monjalon
2015-02-24  3:00               ` Yerden Zhumabekov
2015-02-24  3:10                 ` Thomas Monjalon
2015-02-24  9:12                   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546D5A4B.8030803@sts.kz \
    --to=e_zhumabekov@sts.kz \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).