From: Renyong Wan <wanry@3snic.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>,
Steven Song <steven.song@3snic.com>
Subject: Re: [PATCH 08/32] net/sssnic/base: add work queue
Date: Thu, 7 Sep 2023 10:09:23 +0800 [thread overview]
Message-ID: <547ced53-b77e-494c-a849-bf954d44f60a@3snic.com> (raw)
In-Reply-To: <20230906080918.7c0545dd@hermes.local>
Hello Stephen,
Thanks for your kindly review.
sssnic_workq is quite different from rte_ring, it's used to maintain
information of hardware work queue, like Rx work queue, Tx work queue
etc. Unlike rte_ring the elements of sssnic_workq are organized in a
blcok of contiguous DMA memory accessed by hardware work queue, in
addition the sssnic_workq records CI(consumer index) and PI(producer
index) that synchronize with hardware work queue, driver generally
accesses element of sssnic_workq by PI or CI. Therefore I don't think
rte_ring is suitable for sssnic_workq.
On 2023/9/6 23:09, Stephen Hemminger wrote:
> On Tue, 29 Aug 2023 15:58:05 +0800w
> <wanry@3snic.com> wrote:
>
>> From: Renyong Wan <wanry@3snic.com>
>>
>> Work queue is used to maintain hardware queue information by
>> driver, it is usually used in control queue, rx queue
>> and tx queue.
>>
>> Signed-off-by: Steven Song <steven.song@3snic.com>
>> Signed-off-by: Renyong Wan <wanry@3snic.com>
> Looks like this driver is reinventing rte_ring.
> Please don't do this.
--
Regards,
Renyong Wan
next prev parent reply other threads:[~2023-09-07 2:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 7:57 [PATCH 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters wanry
2023-08-29 7:57 ` [PATCH 01/32] net/sssnic: add build and doc infrastructure wanry
2023-08-29 7:57 ` [PATCH 02/32] net/sssnic: add log type and log macros wanry
2023-08-29 7:58 ` [PATCH 03/32] net/sssnic: support probe and remove wanry
2023-08-29 7:58 ` [PATCH 04/32] net/sssnic: initialize hardware base wanry
2023-08-29 7:58 ` [PATCH 05/32] net/sssnic: add event queue wanry
2023-08-29 7:58 ` [PATCH 06/32] net/sssnic/base: add message definition and utility wanry
2023-08-29 7:58 ` [PATCH 07/32] net/sssnic/base: add mailbox support wanry
2023-08-29 7:58 ` [PATCH 08/32] net/sssnic/base: add work queue wanry
2023-09-06 15:09 ` Stephen Hemminger
2023-09-07 2:09 ` Renyong Wan [this message]
2023-08-29 7:58 ` [PATCH 09/32] net/sssnic/base: add control queue wanry
2023-08-29 7:58 ` [PATCH 10/32] net/sssnic: add dev configure and infos get wanry
2023-08-29 7:58 ` [PATCH 11/32] net/sssnic: add dev MAC ops wanry
2023-08-29 7:58 ` [PATCH 12/32] net/sssnic: support dev link status wanry
2023-08-29 7:58 ` [PATCH 13/32] net/sssnic: support link status event wanry
2023-08-29 7:58 ` [PATCH 14/32] net/sssnic: support Rx queue setup and release wanry
2023-08-29 7:58 ` [PATCH 15/32] net/sssnic: support Tx " wanry
2023-08-29 7:58 ` [PATCH 16/32] net/sssnic: support Rx queue start and stop wanry
2023-08-29 7:58 ` [PATCH 17/32] net/sssnic: support Tx " wanry
2023-08-29 7:58 ` [PATCH 18/32] net/sssnic: add Rx interrupt support wanry
2023-08-29 7:58 ` [PATCH 19/32] net/sssnic: support dev start and stop wanry
2023-08-29 7:58 ` [PATCH 20/32] net/sssnic: support dev close and reset wanry
2023-08-29 7:58 ` [PATCH 21/32] net/sssnic: add allmulticast and promiscuous ops wanry
2023-08-29 7:58 ` [PATCH 22/32] net/sssnic: add basic and extended stats ops wanry
2023-08-29 7:58 ` [PATCH 23/32] net/sssnic: support Rx packet burst wanry
2023-08-29 7:58 ` [PATCH 24/32] net/sssnic: support Tx " wanry
2023-08-29 7:58 ` [PATCH 25/32] net/sssnic: add RSS support wanry
2023-08-29 7:58 ` [PATCH 26/32] net/sssnic: support dev MTU set wanry
2023-08-29 7:58 ` [PATCH 27/32] net/sssnic: support dev queue info get wanry
2023-08-29 7:58 ` [PATCH 28/32] net/sssnic: support dev firmware version get wanry
2023-08-29 7:58 ` [PATCH 29/32] net/sssnic: add dev flow control ops wanry
2023-08-29 7:58 ` [PATCH 30/32] net/sssnic: support VLAN offload and filter wanry
2023-08-29 7:58 ` [PATCH 31/32] net/sssnic: add generic flow ops wanry
2023-08-29 7:58 ` [PATCH 32/32] net/sssnic: add VF dev support wanry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547ced53-b77e-494c-a849-bf954d44f60a@3snic.com \
--to=wanry@3snic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=steven.song@3snic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).