From: Olivier MATZ <olivier.matz@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 3/3] mbuf:replace the inner_l2_len and the inner_l3_len fields
Date: Fri, 05 Dec 2014 12:12:53 +0100 [thread overview]
Message-ID: <54819335.20703@6wind.com> (raw)
In-Reply-To: <1417532767-1309-4-git-send-email-jijiang.liu@intel.com>
Hi,
On 12/02/2014 04:06 PM, Jijiang Liu wrote:
> Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field, and rework csum forward engine and i40e PMD due to these changes.
>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
> app/test-pmd/csumonly.c | 58 +++++++++++++++++++++------------------
> lib/librte_mbuf/rte_mbuf.h | 4 +-
> lib/librte_pmd_i40e/i40e_rxtx.c | 38 +++++++++++++------------
> 3 files changed, 53 insertions(+), 47 deletions(-)
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
One minor comment below:
> @@ -303,8 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
> * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control
> * wether a checksum must be calculated in software or in hardware. The
> * IP, UDP, TCP and SCTP flags always concern the inner layer. The
> - * VxLAN flag concerns the outer IP and UDP layer (if packet is
> - * recognized as a vxlan packet).
> + * VxLAN flag concerns the outer IP(if packet is recognized as a vxlan packet).
> */
> static void
> pkt_burst_checksum_forward(struct fwd_stream *fs)
Typo (no space before parenthesis)
Regards,
Olivier
next prev parent reply other threads:[~2014-12-05 11:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:06 [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework Jijiang Liu
2014-12-02 15:06 ` [dpdk-dev] [PATCH v5 1/3] mbuf:redefine three TX ol_flags Jijiang Liu
2014-12-03 11:35 ` Olivier MATZ
2014-12-02 15:06 ` [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM Jijiang Liu
2014-12-03 11:41 ` Olivier MATZ
2014-12-03 12:59 ` Ananyev, Konstantin
2014-12-03 14:41 ` Olivier MATZ
2014-12-04 2:08 ` Liu, Jijiang
2014-12-04 10:23 ` Ananyev, Konstantin
2014-12-04 10:45 ` Thomas Monjalon
2014-12-04 11:03 ` Ananyev, Konstantin
2014-12-04 13:51 ` Olivier MATZ
2014-12-04 22:56 ` Ananyev, Konstantin
2014-12-05 4:17 ` Liu, Jijiang
2014-12-04 6:52 ` Zhang, Helin
2014-12-04 7:52 ` Liu, Jijiang
2014-12-04 10:19 ` Ananyev, Konstantin
2014-12-04 13:47 ` Olivier MATZ
2014-12-04 21:42 ` Ananyev, Konstantin
2014-12-05 1:15 ` Zhang, Helin
2014-12-05 11:11 ` Olivier MATZ
2014-12-02 15:06 ` [dpdk-dev] [PATCH v5 3/3] mbuf:replace the inner_l2_len and the inner_l3_len fields Jijiang Liu
2014-12-03 11:45 ` Olivier MATZ
2014-12-05 11:12 ` Olivier MATZ [this message]
2014-12-02 15:40 ` [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework Ananyev, Konstantin
2014-12-05 16:07 ` Thomas Monjalon
2014-12-07 11:46 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54819335.20703@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).