From: Olivier MATZ <olivier.matz@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Liu, Jijiang" <jijiang.liu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine
Date: Fri, 09 Jan 2015 11:45:18 +0100 [thread overview]
Message-ID: <54AFB13E.2080200@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213D3897@irsmsx105.ger.corp.intel.com>
Hi,
Thank you Jijiang for taking the time to get back on this.
On 01/08/2015 11:54 AM, Ananyev, Konstantin wrote:
>> And we are able to test all of cases in http://dpdk.org/ml/archives/dev/2014-December/009213.html
>>
>> Test case A:
>>
>> tx_checksum set sw-tunnel-mode off
>> tx_checksum set hw-tunnel-mode off
>> tx_checksum set ip hw
>>
>> test case B.1:
>>
>> tx_checksum set sw-tunnel-mode on
>> tx_checksum set hw-tunnel-mode on
>> tx_checksum set ip hw
>> tx_checksum set tcp hw
>>
>> test case B.2:
>>
>> tx_checksum set sw-tunnel-mode on
>> tx_checksum set hw-tunnel-mode off
>> tx_checksum set ip hw
>>
>> test case C:
>>
>> tx_checksum set sw-tunnel-mode on
>> tx_checksum set hw-tunnel-mode on
>> tx_checksum set outer-ip hw
>> tx_checksum set ip hw
>> tx_checksum set tcp hw
There is something I don't understand. A forward engine takes any packet
in input and output. Packets can be of any kind (eth/arp, eth/ip/tcp,
eth/vlan/ip/udp/vxlan/eth/ip/tcp, ...)
Today, the behavior of csum forward engine is defined for any kind of
packet. See the description and the table in
http://dpdk.org/ml/archives/dev/2014-December/009886.html
All packets that are not "Ether[/vlan]/(IP|IP6)/(UDP|TCP|SCTP)" or
"Ether[/vlan]/(IP|IP6)/UDP/VxLAN/Ether[/vlan]/(IP|IP6)/UDP|TCP|SCTP"
are forwarded without beeing modified.
In my understanding, the use-case you are describing correspond to
specific packet types. So a configuration would work only for one
packet format only. Is it correct?
I think that the test-pmd command API should define a behavior for
the csum forward engine for any packet. What do you think?
Regards,
Olivier
next prev parent reply other threads:[~2015-01-09 10:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 1:03 Jijiang Liu
2014-12-10 1:03 ` [dpdk-dev] [PATCH v3 1/3] librte_ether:add outer IP offload capability flag Jijiang Liu
2014-12-11 10:33 ` Olivier MATZ
2014-12-10 1:03 ` [dpdk-dev] [PATCH v3 2/3] i40e:support outer IPv4 checksum capability Jijiang Liu
2014-12-11 10:34 ` Olivier MATZ
2014-12-10 1:03 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum command and csum forwarding engine Jijiang Liu
2014-12-11 10:52 ` Olivier MATZ
2014-12-12 4:06 ` Liu, Jijiang
2014-12-11 10:17 ` [dpdk-dev] [PATCH v3 0/3] enhance TX checksum " Olivier MATZ
2014-12-12 3:48 ` Liu, Jijiang
2014-12-12 16:33 ` Olivier MATZ
2015-01-07 2:03 ` Liu, Jijiang
2015-01-07 9:59 ` Ananyev, Konstantin
2015-01-07 11:39 ` Liu, Jijiang
2015-01-07 12:07 ` Ananyev, Konstantin
2015-01-08 8:51 ` Liu, Jijiang
2015-01-08 10:54 ` Ananyev, Konstantin
2015-01-09 10:45 ` Olivier MATZ [this message]
2015-01-12 3:41 ` Liu, Jijiang
2015-01-12 11:43 ` Olivier MATZ
2015-01-13 3:04 ` Liu, Jijiang
2015-01-13 9:55 ` Olivier MATZ
2015-01-14 3:01 ` Liu, Jijiang
2015-01-15 13:31 ` Ananyev, Konstantin
2015-01-16 17:27 ` Olivier MATZ
2015-01-19 13:04 ` Ananyev, Konstantin
2015-01-19 14:38 ` Olivier MATZ
2015-01-20 1:12 ` Ananyev, Konstantin
2015-01-20 12:39 ` Olivier MATZ
2015-01-20 15:18 ` Thomas Monjalon
2015-01-20 17:10 ` Stephen Hemminger
2015-01-20 17:23 ` Ananyev, Konstantin
2015-01-20 18:15 ` Olivier MATZ
2015-01-21 3:12 ` Liu, Jijiang
2015-01-21 15:25 ` Olivier MATZ
2015-01-21 16:28 ` Ananyev, Konstantin
2015-01-21 17:13 ` Olivier MATZ
2015-01-26 4:13 ` Ananyev, Konstantin
2015-01-26 6:02 ` Liu, Jijiang
2015-01-26 14:07 ` Olivier MATZ
2015-01-26 14:15 ` Ananyev, Konstantin
2015-01-27 8:34 ` Olivier MATZ
2015-01-27 15:26 ` Ananyev, Konstantin
2015-01-21 19:44 ` Stephen Hemminger
2015-01-22 1:40 ` Liu, Jijiang
2015-01-21 8:01 ` Liu, Jijiang
2015-01-21 9:10 ` Olivier MATZ
2015-01-21 11:52 ` Ananyev, Konstantin
2015-01-07 13:06 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AFB13E.2080200@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).