From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Tomasz Duszynski <tdu@semihalf.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table
Date: Fri, 12 Jan 2018 13:07:34 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BAFBFA4@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Thursday, January 11, 2018 6:34 PM
> To: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions
> table
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, January 11, 2018 1:49 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions
> > table
> >
> > Since METER action is supported by the testpmd application suitable
> > entry should exist in flow actions information table.
> >
> > Without that testpmd will return error on adding a new flow to the
> > list of flows attached to a given port.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> > app/test-pmd/config.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 0a84481..4ad19fb 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1038,6 +1038,7 @@ static const struct {
> > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /*
> > +queue[] */
> > MK_FLOW_ACTION(PF, 0),
> > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)),
> > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)),
> > };
> >
> > /** Compute storage space needed by action configuration. */
> > --
> > 2.7.4
>
> Adding Jasvinder to this thread.
The above change looks fine to me.
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2018-01-12 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 13:49 Tomasz Duszynski
2018-01-11 18:33 ` Dumitrescu, Cristian
2018-01-12 13:07 ` Singh, Jasvinder [this message]
2018-01-22 7:28 ` Tomasz Duszynski
2018-01-28 11:58 ` Tomasz Duszynski
2018-01-30 10:00 ` Adrien Mazarguil
2018-01-31 22:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=tdu@semihalf.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).