From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: allow setting shaper profile id to none
Date: Fri, 16 Feb 2018 09:38:40 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D332FA7C3@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20180216081339.GB25327@sh>
<snip>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Friday, February 16, 2018 8:14 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: allow setting shaper profile id
> to none
>
> On Tue, Jan 30, 2018 at 08:37:08AM +0100, Tomasz Duszynski wrote:
> > Private shaper profiles are attached to nodes defined in traffic
> > manager hierarchy.
> >
> > Since not every node must have a configured shaper testpmd should
> > allow setting shaper profile id to invalid
> > (RTE_TM_SHAPER_PROFILE_ID_NONE) easily.
> >
> > This patch follows same approach as in case of setting parent id of
> > the root node i.e passing a negative value sets node id to
> > RTE_TM_NODE_ID_NULL.
> >
> > In case of private shaper profile negative value will set shaper
> > profile id to RTE_TM_SHAPER_PROFILE_ID_NONE.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2018-02-16 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 7:37 Tomasz Duszynski
2018-02-16 8:13 ` Tomasz Duszynski
2018-02-16 9:38 ` Singh, Jasvinder [this message]
2018-04-23 19:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D332FA7C3@IRSMSX103.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=tdu@semihalf.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).