From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipipeline: fix resource leak
Date: Thu, 19 Apr 2018 08:37:07 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D33341990@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1524070690-12000-3-git-send-email-reshma.pattan@intel.com>
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Wednesday, April 18, 2018 5:58 PM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.singh@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>
> Subject: [PATCH] examples/ip_pipipeline: fix resource leak
>
> Close tap device fd before returning upon failures.
>
> Coverity issue: 272576
> Fixes: 2f74ae28e2 ("examples/ip_pipeline: add tap object")
> CC: jasvinder.singh@intel.com
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> examples/ip_pipeline/tap.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/examples/ip_pipeline/tap.c b/examples/ip_pipeline/tap.c index
> 5b3403218..a0f60867f 100644
> --- a/examples/ip_pipeline/tap.c
> +++ b/examples/ip_pipeline/tap.c
> @@ -76,14 +76,17 @@ tap_create(const char *name)
> snprintf(ifr.ifr_name, IFNAMSIZ, "%s", name);
>
> status = ioctl(fd, TUNSETIFF, (void *) &ifr);
> - if (status < 0)
> + if (status < 0) {
> + close(fd);
> return NULL;
> + }
>
> /* Node allocation */
> tap = calloc(1, sizeof(struct tap));
> - if (tap == NULL)
> + if (tap == NULL) {
> + close(fd);
> return NULL;
> -
> + }
> /* Node fill in */
> strncpy(tap->name, name, sizeof(tap->name));
> tap->fd = fd;
> --
> 2.14.3
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2018-04-19 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 16:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Reshma Pattan
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Reshma Pattan
2018-04-19 8:36 ` Singh, Jasvinder
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipipeline: fix resource leak Reshma Pattan
2018-04-19 8:37 ` Singh, Jasvinder [this message]
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Reshma Pattan
2018-04-19 8:35 ` Singh, Jasvinder
2018-04-19 8:37 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D33341990@IRSMSX101.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).