From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak
Date: Thu, 19 Apr 2018 15:32:49 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D33342B8F@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20180419110418.8099-1-kevin.laatz@intel.com>
> -----Original Message-----
> From: Laatz, Kevin
> Sent: Thursday, April 19, 2018 12:04 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix resource leak
>
> Closing the fd_server file descriptor on error to fix the resource leak.
>
> Coverity issue: 272587
> Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")
> Cc: jasvinder.singh@intel.com
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> examples/ip_pipeline/conn.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/examples/ip_pipeline/conn.c b/examples/ip_pipeline/conn.c index
> 9338942..6b08e9e 100644
> --- a/examples/ip_pipeline/conn.c
> +++ b/examples/ip_pipeline/conn.c
> @@ -96,12 +96,14 @@ conn_init(struct conn_params *p)
> sizeof(server_address));
> if (status == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> status = listen(fd_server, 16);
> if (status == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> @@ -109,6 +111,7 @@ conn_init(struct conn_params *p)
> fd_client_group = epoll_create(1);
> if (fd_client_group == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> --
> 2.9.5
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
prev parent reply other threads:[~2018-04-19 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 11:04 Kevin Laatz
2018-04-19 15:32 ` Singh, Jasvinder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D33342B8F@IRSMSX101.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).