From: Olivier MATZ <olivier.matz@6wind.com>
To: Xuelin Shi <xuelin.shi@freescale.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fix testpmd show port info error
Date: Thu, 05 Feb 2015 10:58:40 +0100 [thread overview]
Message-ID: <54D33ED0.1030603@6wind.com> (raw)
In-Reply-To: <CY1PR0301MB0684331C3A2ADAF8938A13F6863B0@CY1PR0301MB0684.namprd03.prod.outlook.com>
Hi,
On 02/05/2015 10:26 AM, Xuelin Shi wrote:
> Hi,
>
> Anybody interested in this patch could have a review or comment on it?
> I'm new here. Should I send this patch to some specific maintainer to make this more efficient?
>
> Thanks,
> Shi Xuelin
>
> -----Original Message-----
> From: xuelin.shi@freescale.com [mailto:xuelin.shi@freescale.com]
> Sent: Monday, February 02, 2015 14:52
> To: dev@dpdk.org
> Cc: Shi Xuelin-B29237
> Subject: [PATCH] fix testpmd show port info error
>
> From: Xuelin Shi <xuelin.shi@freescale.com>
>
> the port number type should be consistent with librte_cmdline, else there is potential endian issue.
>
> Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
> ---
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4beb404..488ac63 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -5568,7 +5568,7 @@ cmdline_parse_token_string_t cmd_showport_what =
> TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
> "info#stats#xstats#fdir#stat_qmap");
> cmdline_parse_token_num_t cmd_showport_portnum =
> - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32);
> + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT8);
>
> cmdline_parse_inst_t cmd_showport = {
> .f = cmd_showport_parsed,
> --
Thank you for reporting this. However I think it should be UINT8
instead of INT8.
According to http://dpdk.org/dev, I think a better title could be
"testpmd: fix port parsing in show port info command"
Apart from this,
Acked-by: Olivier Matz <olivier.matz@6wind.com>
I think it would be less work for Thomas if you can submit
a v2 that includes these 2 changes.
Regards,
Olivier
next prev parent reply other threads:[~2015-02-05 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 6:51 xuelin.shi
2015-02-05 9:26 ` Xuelin Shi
2015-02-05 9:58 ` Olivier MATZ [this message]
2015-02-06 2:00 ` Xuelin Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D33ED0.1030603@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).