From: Olivier MATZ <olivier.matz@6wind.com>
To: xuelin.shi@freescale.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix port parsing in show port info command
Date: Fri, 06 Feb 2015 09:30:44 +0100 [thread overview]
Message-ID: <54D47BB4.9020005@6wind.com> (raw)
In-Reply-To: <1423186160-26035-1-git-send-email-xuelin.shi@freescale.com>
Hi,
On 02/06/2015 02:29 AM, xuelin.shi@freescale.com wrote:
> From: Xuelin Shi <xuelin.shi@freescale.com>
>
> the port number type should be consistent with librte_cmdline,
> else there is potential endian issue.
>
> Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
> ---
> v2 change:
> change port type to uint8
> rephrase patch title
>
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 590e427..d5f31f2 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -5584,7 +5584,7 @@ cmdline_parse_token_string_t cmd_showport_what =
> TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
> "info#stats#xstats#fdir#stat_qmap");
> cmdline_parse_token_num_t cmd_showport_portnum =
> - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32);
> + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8);
>
> cmdline_parse_inst_t cmd_showport = {
> .f = cmd_showport_parsed,
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2015-02-06 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 1:29 xuelin.shi
2015-02-06 8:30 ` Olivier MATZ [this message]
2015-02-15 15:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D47BB4.9020005@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).