From: Panu Matilainen <pmatilai@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Make -Werror optional
Date: Thu, 12 Feb 2015 15:58:07 +0200 [thread overview]
Message-ID: <54DCB16F.7080104@redhat.com> (raw)
In-Reply-To: <20150212120834.GC10216@bricha3-MOBL3>
On 02/12/2015 02:08 PM, Bruce Richardson wrote:
> On Thu, Feb 12, 2015 at 02:02:19PM +0200, Panu Matilainen wrote:
>> On 02/12/2015 01:25 PM, Bruce Richardson wrote:
>>> On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote:
>>>> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable
>>>> fail-on-warning compile behavior, defaulting to off.
>>>>
>>>> Failing build on warnings is a useful developer tool but its bad
>>>> for release tarballs which can and do get built with newer
>>>> compilers than what was used/available during development. Compilers
>>>> routinely add new warnings so code which built silently with cc X
>>>> might no longer do so with X+1. This doesn't make the existing code
>>>> any more buggier and failing the build in this case does not help
>>>> not help improve code quality of an already released version either.
>>>
>>> This can already be achieve by passing EXTRA_CFLAGS='-Wno-error' into the
>>> build command. I don't like changing the default option here. Better to
>>> instead document how to disable the warning flags if necessary.
>>
>> Well, optimally it would only default to off in released versions, which is
>> where the Werror behavior is just annoying without being useful.
>
> This I can agree with.
Ok, would something to this tune be more acceptable?
diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk
index d5b36be..2ad969b 100644
--- a/mk/rte.vars.mk
+++ b/mk/rte.vars.mk
@@ -71,6 +71,10 @@ ifneq ($(BUILDING_RTE_SDK),)
ifeq ($(RTE_BUILD_COMBINE_LIBS),)
RTE_BUILD_COMBINE_LIBS := n
endif
+ # see if we're building from git
+ ifneq ($(wildcard $(RTE_SDK)/.git),)
+ DEVEL_BUILD := y
+ endif
endif
RTE_LIBNAME := $(CONFIG_RTE_LIBNAME:"%"=%)
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index 88f235c..a14ae44 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -71,12 +71,16 @@ ifeq (,$(findstring -O0,$(EXTRA_CFLAGS)))
endif
endif
-WERROR_FLAGS := -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes
+WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes
WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition
-Wpointer-arith
WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual
WERROR_FLAGS += -Wformat-nonliteral -Wformat-security
WERROR_FLAGS += -Wundef -Wwrite-strings
+ifeq ($(DEVEL_BUILD),y)
+WERROR_FLAGS += -Werror
+endif
+
# process cpu flags
include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
(non-gcc toolchains are missing and whitespace probably broken due to
copy-paste, this is not a suggested patch but just an RFC for the approach)
- Panu -
next prev parent reply other threads:[~2015-02-12 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:13 Panu Matilainen
2015-02-12 11:25 ` Bruce Richardson
2015-02-12 12:02 ` Panu Matilainen
2015-02-12 12:08 ` Bruce Richardson
2015-02-12 13:58 ` Panu Matilainen [this message]
2015-02-12 14:02 ` Bruce Richardson
2015-02-12 14:05 ` Thomas Monjalon
2015-02-12 15:18 ` [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout Panu Matilainen
2015-02-20 12:15 ` Thomas Monjalon
2015-02-21 2:15 ` Stephen Hemminger
2015-02-21 10:48 ` Thomas Monjalon
2016-03-02 14:22 ` [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build Thomas Monjalon
2016-03-02 22:04 ` Bruce Richardson
2016-03-03 10:36 ` Thomas Monjalon
2016-03-03 10:53 ` Panu Matilainen
2015-02-12 14:38 ` [dpdk-dev] [PATCH] Make -Werror optional Stephen Hemminger
2015-02-12 14:54 ` Panu Matilainen
2015-02-21 1:55 ` Stephen Hemminger
2015-02-21 19:33 ` Neil Horman
2015-02-23 8:19 ` Panu Matilainen
2015-02-23 13:55 ` Neil Horman
2015-02-23 14:20 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCB16F.7080104@redhat.com \
--to=pmatilai@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).