From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Michael Qiu <michael.qiu@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix action of operationg invalid port
Date: Mon, 09 Mar 2015 15:11:07 +0900 [thread overview]
Message-ID: <54FD397B.9010707@igel.co.jp> (raw)
In-Reply-To: <1425881147-27600-1-git-send-email-michael.qiu@intel.com>
On 2015/03/09 15:05, Michael Qiu wrote:
> Currently, if try to start/stop/close one invalid prot,
> no error shows in testpmd.
> This is a bug, need check the port number.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> app/test-pmd/config.c | 3 +++
> app/test-pmd/testpmd.c | 14 ++++++++++++--
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 49be819..ec53923 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -384,6 +384,9 @@ port_infos_display(portid_t port_id)
> int
> port_id_is_invalid(portid_t port_id, enum print_warning warning)
> {
> + if (port_id == (portid_t)RTE_PORT_ALL)
> + return 0;
> +
> if (ports[port_id].enabled)
> return 0;
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e556b4c..1c4c651 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1326,6 +1326,9 @@ start_port(portid_t pid)
> return -1;
> }
>
> + if (port_id_is_invalid(pid, ENABLED_WARN))
> + return 0;
> +
> if (init_fwd_streams() < 0) {
> printf("Fail from init_fwd_streams()\n");
> return -1;
> @@ -1482,10 +1485,14 @@ stop_port(portid_t pid)
> dcb_test = 0;
> dcb_config = 0;
> }
> +
> + if (port_id_is_invalid(pid, ENABLED_WARN))
> + return;
> +
> printf("Stopping ports...\n");
>
> FOREACH_PORT(pi, ports) {
> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != pi)
> + if (pid != pi && pid != (portid_t)RTE_PORT_ALL)
> continue;
>
> port = &ports[pi];
> @@ -1517,10 +1524,13 @@ close_port(portid_t pid)
> return;
> }
>
> + if (port_id_is_invalid(pid, ENABLED_WARN))
> + return;
> +
> printf("Closing ports...\n");
>
> FOREACH_PORT(pi, ports) {
> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != pi)
> + if (pid != pi && pid != (portid_t)RTE_PORT_ALL)
> continue;
>
> port = &ports[pi];
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
next prev parent reply other threads:[~2015-03-09 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 6:05 Michael Qiu
2015-03-09 6:11 ` Tetsuya Mukawa [this message]
2015-03-09 11:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD397B.9010707@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).