From: Andy Green <andy@warmcat.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation
Date: Tue, 15 May 2018 18:19:19 +0800 [thread overview]
Message-ID: <54ecbab4-185e-2da6-8733-f40cc0648aa1@warmcat.com> (raw)
In-Reply-To: <20180515100335.13051-1-jerin.jacob@caviumnetworks.com>
On 05/15/2018 06:03 PM, Jerin Jacob wrote:
> sizeof(dri_name) is 8B on 64Bit systems.The intended operation is coping
> the string after '/' from the string `name`.
>
> This bug is not letting to probe any device string >8B hence results in
> the testpmd error("No ethernet devices found) on some PMDs.
You are right... but...
> Cc: Andy Green <andy@warmcat.com>
> Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Fixes: fe5f777b538 ("bus/pci: replace strncpy by strlcpy")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/bus/pci/linux/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> index a73ee49c2..cd45875b1 100644
> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -54,7 +54,7 @@ pci_get_kernel_driver_by_path(const char *filename, char *dri_name)
>
> name = strrchr(path, '/');
> if (name) {
> - strlcpy(dri_name, name + 1, sizeof(dri_name));
> + strlcpy(dri_name, name + 1, strlen(name));
... this fix is no good. The underlying problem is the length of
dri_name is not getting passed into this function... it just doesn't
know how much of dri_name is safe to use. Telling it to use the
strlen() of something unrelated is going to make buffer overflows possible.
I sent a patch to the list a few hours ago that amends this function to
take the allocated length of dri_name, and sets the limit for the
strlcpy() to that, so no matter what turns up in name it's not possible
to blow past dri_name allocation.
[dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion
-Andy
> return 0;
> }
>
>
next prev parent reply other threads:[~2018-05-15 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 10:03 Jerin Jacob
2018-05-15 10:19 ` Andy Green [this message]
2018-05-15 10:31 ` Jerin Jacob
2018-05-15 10:41 ` Andy Green
2018-05-15 10:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ecbab4-185e-2da6-8733-f40cc0648aa1@warmcat.com \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).