From: Vlad Zolotarov <vladz@cloudius-systems.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow
Date: Fri, 13 Mar 2015 13:51:52 +0200 [thread overview]
Message-ID: <5502CF58.3050504@cloudius-systems.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com>
On 03/13/15 13:07, Ananyev, Konstantin wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov
>> Sent: Thursday, March 12, 2015 9:17 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow
>>
>> This series contains some bug fixes that were found during my work on the ixgbe LRO
>> patches. Sending this series separately on Thomas request so that it may be integrated
>> into the 2.0 release.
>>
>> New in v3:
>> - Adjusted to the new structs naming in the master.
>> - Fixed rx_bulk_alloc_allowed and rx_vec_allowed initialization:
>> - Don't set them to FALSE in rte_eth_dev_stop() flow - the following
>> rte_eth_dev_start() will need them.
>> - Reset them to TRUE in rte_eth_dev_configure() and not in a probe() flow.
>> This will ensure the proper behaviour if port is re-configured.
>> - Rename:
>> - ixgbe_rx_vec_condition_check() -> ixgbe_rx_vec_dev_conf_condition_check()
>> - set_rx_function() -> ixgbe_set_rx_function()
>> - Clean up the logic in ixgbe_set_rx_function().
>> - Define stubs with __attribute__((weak)) instead of using #ifdef's.
>> - Styling: beautify ixgbe_rxtx.h a bit.
>>
>> New in v2:
>> - Fixed a compilation failure.
>>
>>
>> Vlad Zolotarov (3):
>> ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when
>> reading/setting HW ring descriptor fields
>> ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices
>> ixgbe: Unify the rx_pkt_bulk callback initialization
>>
>> lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 +
>> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +-
>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 +++++++++++++++++++++-----------
>> lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++-
>> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
>> 5 files changed, 183 insertions(+), 78 deletions(-)
>>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Just one nit:
>
> +int __attribute__((weak)) ixgbe_rxq_vec_setup(
> + struct ixgbe_rx_queue __rte_unused *rxq)
> +{
>
> Please use notation:
> int __attribute__((weak))
> ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq)
>
> To keep up with the rest of the code, plus makes much easier to read.
I took an example from kni/ethtool/igb/kcompat.h for a template but no
problem.
Do u want me to respin or it's ok? I will use this format for the
follow-up LRO patch anyway...
>
>> --
>> 2.1.0
next prev parent reply other threads:[~2015-03-13 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 21:17 Vlad Zolotarov
2015-03-12 21:17 ` [dpdk-dev] [PATCH v3 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields Vlad Zolotarov
2015-03-12 21:17 ` [dpdk-dev] [PATCH v3 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices Vlad Zolotarov
2015-03-12 21:17 ` [dpdk-dev] [PATCH v3 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization Vlad Zolotarov
2015-03-13 11:07 ` [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow Ananyev, Konstantin
2015-03-13 11:51 ` Vlad Zolotarov [this message]
2015-03-13 12:51 ` Ananyev, Konstantin
2015-03-13 13:03 ` Vladislav Zolotarov
2015-03-16 7:52 ` Vlad Zolotarov
2015-03-16 10:19 ` Thomas Monjalon
2015-03-16 23:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502CF58.3050504@cloudius-systems.com \
--to=vladz@cloudius-systems.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).