From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes
Date: Thu, 25 Oct 2018 02:07:22 +0200 [thread overview]
Message-ID: <5568978.q47av0dVMy@xps> (raw)
In-Reply-To: <ed663339-f328-dbea-4254-dad3db3bb660@nxp.com>
16/10/2018 13:52, Shreyansh Jain:
> On Monday 15 October 2018 08:20 PM, Ferruh Yigit wrote:
> > These libraries has exported functions but the target of those functions
> > are not user but other libraries.
> >
> > The version of these libraries doesn't mean much to the user so can be
> > dropped from release notes.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Indeed this is more a question, should we keep them or remove them?
>
> +1 for removing them.
> At least for dpaa/fslmc perspective, I don't see any additional benefit
> in release note. These libraries (dpaa/fslmc) are not actually
> 'libraries' in true (read, plugability) sense :)
> > --- a/doc/guides/rel_notes/release_18_11.rst
> > +++ b/doc/guides/rel_notes/release_18_11.rst
> > - + librte_bus_dpaa.so.2
> > - + librte_bus_fslmc.so.2
> > - + librte_bus_ifpga.so.2
> > - + librte_bus_pci.so.2
> > - + librte_bus_vdev.so.2
> > - + librte_bus_vmbus.so.2
The ABI of bus libraries is important if you want to plug a PMD
into an older DPDK: if bus ABI has changed, you cannot.
I am for keeping them.
> > - librte_pci.so.1
This is a true library!
next prev parent reply other threads:[~2018-10-25 0:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:50 [dpdk-dev] [PATCH 1/6] doc: add missing shared library versions to " Ferruh Yigit
2018-10-15 14:50 ` [dpdk-dev] [PATCH 2/6] doc: remove shared libs with no API from " Ferruh Yigit
2018-10-16 13:01 ` Jerin Jacob
2018-10-15 14:50 ` [dpdk-dev] [PATCH 3/6] doc: fix vhost library version in " Ferruh Yigit
2018-10-16 2:19 ` Tiwei Bie
2018-10-15 14:50 ` [dpdk-dev] [PATCH 4/6] mbuf: fix library version on meson build Ferruh Yigit
2018-10-15 14:25 ` Luca Boccassi
2018-10-15 14:50 ` [dpdk-dev] [PATCH 5/6] ring: add library version to " Ferruh Yigit
2018-10-15 14:26 ` Luca Boccassi
2018-10-15 14:50 ` [dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes Ferruh Yigit
2018-10-16 11:52 ` Shreyansh Jain
2018-10-25 0:07 ` Thomas Monjalon [this message]
2018-10-25 12:31 ` [dpdk-dev] [PATCH 1/6] doc: add missing shared library versions to " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568978.q47av0dVMy@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).